Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jest-jasmine2] Split jasmine-light over multiple files. #3159

Merged
merged 6 commits into from
Mar 17, 2017
Merged

[jest-jasmine2] Split jasmine-light over multiple files. #3159

merged 6 commits into from
Mar 17, 2017

Conversation

wtgtybhertgeghgtwtg
Copy link
Contributor

Summary
Splits jasmine-light over multiple files. Removes unused exports as a side-effect.

Test plan
Nothing should change.

@wtgtybhertgeghgtwtg wtgtybhertgeghgtwtg mentioned this pull request Mar 17, 2017
Merged
@cpojer
Copy link
Member

cpojer commented Mar 17, 2017

This is great. Can we do this:

  • Move all the jasmine files into src/jasmine so we have a clear split between the test runner code and the jest adapter?
  • Add the Facebook copyright header on top of the Jasmine one. These files only use the algorithms from Jasmine but we are going to move away from them entirely.

Maybe something like:

// jest's copyright header
// This file is a heavily modified fork of Jasmine. The original license of the code:
// Jasmine license.

@wtgtybhertgeghgtwtg
Copy link
Contributor Author

Tests failing on Travis due to yarn timing out.

@cpojer cpojer merged commit 4cc5459 into jestjs:master Mar 17, 2017
@wtgtybhertgeghgtwtg wtgtybhertgeghgtwtg deleted the split-jasmine-light branch March 17, 2017 01:52
skovhus pushed a commit to skovhus/jest that referenced this pull request Apr 29, 2017
@wtgtybhertgeghgtwtg @skovhus
[jest-jasmine2] Split jasmine-light over multiple files. (jestjs#3159)
84b3457 
* [jest-jasmine2] Split `jasmine-light` over multiple files.

* Don't wrap things that don't need to be wrapped.

* Don't wrap things that don't need to be wrapped (again).

* Lint.

* Move source to `jasmine`, alter license.
tushardhole pushed a commit to tushardhole/jest that referenced this pull request Aug 21, 2017
@wtgtybhertgeghgtwtg @cpojer
[jest-jasmine2] Split jasmine-light over multiple files. (jestjs#3159)
b119ce2 
* [jest-jasmine2] Split `jasmine-light` over multiple files.

* Don't wrap things that don't need to be wrapped.

* Don't wrap things that don't need to be wrapped (again).

* Lint.

* Move source to `jasmine`, alter license.
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed ✔️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wtgtybhertgeghgtwtg @cpojer @facebook-github-bot