feat(jest-core): add support for globalSetup and globalTeardown written in ESM

[aledalgrande]

Summary

Adds support for globalSetup when using Jest in ESM mode. Potentially adds support for globalTeardown too, but will leave tests for that in a separate PR.

Works towards completing #11167.

I did not use requireOrImportModule because it seemed the flow here was a bit different from the other cases, but let me know if you want that changed. Also left formatting to Prettier/ESLint, hope that worked well.

Test plan

Tests are attached. I took inspiration from other PRs/existing code, hope it makes sense.

[aledalgrande]

Not sure why the snapshot test file has been affected here.

[aledalgrande]

Only Windows latest failing at the installation step now.

[aledalgrande]

@SimenB do you know why the Windows / Node 15 would fail?

[SimenB]

@aledalgrande sorry about the slow response here. Windows is failing due to an install issue (#11229) and can be safely ignored 🙂

[codecov-io]

Codecov Report

Merging #11267 (90ef5c2) into master (4926564) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #11267      +/-   ##
==========================================
- Coverage   64.23%   64.20%   -0.03%     
==========================================
  Files         308      308              
  Lines       13512    13521       +9     
  Branches     3292     3295       +3     
==========================================
+ Hits         8679     8681       +2     
- Misses       4120     4128       +8     
+ Partials      713      712       -1     

Impacted Files	Coverage Δ
packages/jest-core/src/runGlobalHook.ts	15.62% <0.00%> (-6.12%)	⬇️
packages/expect/src/utils.ts	96.12% <0.00%> (+1.29%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4926564...90ef5c2. Read the comment docs.

[SimenB]

Thanks @aledalgrande, this looks good! 👍

When you update runGlobalHook.ts you also add support for globalTeardown - could you add a test for that as well?

[aledalgrande]

@SimenB added a simple test, but I'm getting weird failures. Some about timing and others about logs.

[SimenB]

Thanks @aledalgrande!

[gilles-yvetot]

@SimenB this is not in @next yet right?

[SimenB]

Correct. I can make a new release later today so people can use it 👍

[SimenB]

@gilles-yvetot found some time now, next.9 released

[gilles-yvetot]

@SimenB you are the real MVP

[jakobrosenberg]

I'm trying out next.9, but getting

TypeError: virtualMocks.get is not a function

  at Resolver._getVirtualMockPath (node_modules/@jest/core/node_modules/jest-resolve/build/index.js:448:25) 

The function that errors:

  _getVirtualMockPath(virtualMocks, from, moduleName) {
    console.log({virtualMocks, from, moduleName})  //my console.log
    const virtualMockPath = this.getModulePath(from, moduleName);
    return virtualMocks.get(virtualMockPath)  // line 448
      ? virtualMockPath
      : moduleName
      ? this.resolveModule(from, moduleName)
      : from;
  }

console.logging the input gives me

{
  virtualMocks: {},
  from: '<my-project>\\node_modules\\source-map-support\\source-map-support.js',   
  moduleName: 'source-map-support'
}

It seems I'm only getting the error when using jest-playwright-preset.

[SimenB]

@jakobrosenberg huh, interesting! Could you open up a new issue with a (minimal) reproduction?

[jakobrosenberg]

@SimenB I'll see if I can get one done. In the meantime, I found the same issue here playwright-community/jest-playwright#665

Alas the proposed solution did not work for me.

[SimenB]

I'd assume it's an issue because they pull in v26 deps: https://github.com/playwright-community/jest-playwright/blob/f8ee23108bcac6801f073986a9bba56dfe461c2f/package.json#L48-L51

Should probably be peer deps so users can plug in their own versions.

@SimenB I'll see if I can get one done. In the meantime, I found the same issue here playwright-community/jest-playwright#665

Alas the proposed solution did not work for me.

Hah, right! Makes sense it's the outdated deps. You can try resolutions or something

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.