chore: remove sass from website #11229
Conversation
website/docusaurus.config.js
Outdated
| path.resolve('src/css/docusaurusTheme.css'), | ||
| path.resolve('src/css/algoliaDocSearchTheme.css'), | ||
| path.resolve('static/css/custom.css'), | ||
| path.resolve('static/css/jest.css'), | ||
| path.resolve('src/components/v1/legacyCSS.css'), |
There was a problem hiding this comment.
renamed from scss to css and moved the legacy one to the bottom as it overrides some of the others (and for some reason, webpack produces a different order in the css now)
| } | ||
| } | ||
| /* Temporary fix for not ideal Docusaurus 2 layout */ | ||
| /* May be removed when we close https://github.com/facebook/docusaurus/issues/4083 */ |
There was a problem hiding this comment.
@slorber this is closed - any idea if we can remove the overrides here now?
There was a problem hiding this comment.
It depends on whether the default Docusaurrus blog layout satisfy you or not: https://docusaurus.io/blog/2021/01/19/docusaurus-2020-recap
We improved but you may still want to keep custom CSS. Worth removing this and see if it looks good to you.
|
currently stuck on different css in dev mode and after building. Might just combine into a single css file since the bundling is inconsistent |
|
This blocks adding v16 to CI, so merging even though some styling has changed |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
It causes build failures on Windows due to the native dependency (sometimes, usually 1 out of the 5 Windows builds we have per commit).
/cc @slorber
Test plan
Website should be identical