fix(valid-expect-in-promise): allow variables assigned awaited promises

jest-community · Oct 2, 2021 · a1b103c · a1b103c
1 parent f794b0d
commit a1b103c
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/src/rules/__tests__/valid-expect-in-promise.test.ts b/src/rules/__tests__/valid-expect-in-promise.test.ts
@@ -272,6 +272,17 @@ ruleTester.run('valid-expect-in-promise', rule, {
         return promise;
       });
     `,
+    dedent`
+      it('is a test', async () => {
+        const value = await somePromise().then(response => {
+          expect(response).toHaveProperty('data');
+
+          return response.data;
+        });
+
+        expect(value).toBe('hello world');
+      });
+    `,
     dedent`
       it(
         'test function',

diff --git a/src/rules/valid-expect-in-promise.ts b/src/rules/valid-expect-in-promise.ts
@@ -138,6 +138,10 @@ const isVariableAwaitedOrReturned = (
   const [variable] = variables.declarations;
   const name = getVariableName(variable);
 
+  if (variable.init?.type === AST_NODE_TYPES.AwaitExpression) {
+    return true;
+  }
+
   // null means that the variable is destructured, which is pretty much impossible
   // for us to track, so we return true to bailout gracefully
   if (name === null) {