refactor(valid-expect-in-promise): adjust conditions to dedent code

jest-community · Oct 2, 2021 · f794b0d · f794b0d
1 parent bc86bab
commit f794b0d
Showing 1 changed file with 25 additions and 25 deletions.
diff --git a/src/rules/valid-expect-in-promise.ts b/src/rules/valid-expect-in-promise.ts
@@ -217,32 +217,32 @@ export default createRule<unknown[], MessageIds>({
           return;
         }
 
-        if (isPromiseChainCall(node)) {
-          if (chains.shift()) {
-            const topNode = findStartingStatementInTestBody(node);
-
-            if (!topNode) {
-              return;
-            }
-
-            if (
-              topNode.type === AST_NODE_TYPES.VariableDeclaration &&
-              isVariableAwaitedOrReturned(topNode)
-            ) {
-              return;
-            }
-
-            if (
-              topNode.type === AST_NODE_TYPES.ReturnStatement ||
-              (topNode.type === AST_NODE_TYPES.ExpressionStatement &&
-                topNode.expression.type === AST_NODE_TYPES.AwaitExpression)
-            ) {
-              return;
-            }
-
-            reportReturnRequired(context, topNode);
-          }
+        if (!isPromiseChainCall(node) || !chains.shift()) {
+          return;
+        }
+
+        const topNode = findStartingStatementInTestBody(node);
+
+        if (!topNode) {
+          return;
         }
+
+        if (
+          topNode.type === AST_NODE_TYPES.VariableDeclaration &&
+          isVariableAwaitedOrReturned(topNode)
+        ) {
+          return;
+        }
+
+        if (
+          topNode.type === AST_NODE_TYPES.ReturnStatement ||
+          (topNode.type === AST_NODE_TYPES.ExpressionStatement &&
+            topNode.expression.type === AST_NODE_TYPES.AwaitExpression)
+        ) {
+          return;
+        }
+
+        reportReturnRequired(context, topNode);
       },
     };
   },