cockroach: update use of SPLIT AT #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Happy to merge whenever you're ready. Maybe bump the default version in jepsen.cockroach.runner at the same time? |
|
Thanks! This version jepsen/cockroachdb/project.clj Line 1 in 0f72505 Not sure, @knz please advise. |
|
This one: Line 2 in 0f72505 |
|
And this: |
|
Got it, thanks! I will wait for a beta to be released and update the PR then. |
The syntax of SPLIT AT is being changed in cockroachdb/cockroach#14281.
RaduBerinde
force-pushed
the
update-split-at
branch
from
ce325f1 to
b9a6d1c
Compare
|
I bumped the versions with today's beta. I think it's ready to merge. Thanks! |
|
Here ya go! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The syntax of SPLIT AT is being changed in
cockroachdb/cockroach#14281.
Not sure when we should merge this - as soon as the PR above goes in, or whenever we have a beta release that incorporates it..
CC @knz