sql: change SPLIT AT to take a select statement
#14281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
you can send a PR aphyr will probably take it right away |
maddyblue
approved these changes
Mar 21, 2017
RaduBerinde
added a commit
to RaduBerinde/examples-go
that referenced
this pull request
Mar 21, 2017
RaduBerinde
added a commit
to RaduBerinde/loadgen
that referenced
this pull request
Mar 21, 2017
RaduBerinde
added a commit
to RaduBerinde/loadgen
that referenced
this pull request
Mar 21, 2017
RaduBerinde
added a commit
to RaduBerinde/jepsen
that referenced
this pull request
Mar 21, 2017
The syntax of SPLIT AT is being changed in cockroachdb/cockroach#14281.
Renaming to match the corresponding test file.
`SPLIT AT` now takes an arbitrary select statement. Existing uses must switch to using `VALUES`; e.g. `ALTER TABLE t SPLIT AT (x, y)` becomes `ALTER TABLE t SPLIT AT VALUES (x, y)`. Part of cockroachdb#13665, implements part of RFC cockroachdb#14146.
RaduBerinde
force-pushed
the
split-at-select
branch
from
b39559c to
40f7517
Compare
RaduBerinde
added a commit
to RaduBerinde/jepsen
that referenced
this pull request
Mar 31, 2017
The syntax of SPLIT AT is being changed in cockroachdb/cockroach#14281.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SPLIT ATnow takes an arbitrary select statement. Existing uses must switch tousing
VALUES; e.g.ALTER TABLE t SPLIT AT (x, y)becomesALTER TABLE t SPLIT AT VALUES (x, y).Part of #13665, implements part of RFC #14146.
I will open up PRs to correct
SPLIT ATusage inexamples-goandloadgenrepos. Any other repos we need to fix (other than docs)? Jepsen?CC @andreimatei @knz @mjibson
This change is