-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add actionlint hook and fix current errors #505
Conversation
Ah, I forgot again that we don't create |
aa57c5b
to
96392ac
Compare
c486a9d
to
b9c71a3
Compare
What about something like actionlint-py and shellcheck-py? |
Thanks. I knew about I'm not sure if adding |
I think it does: |
I have already made a note on that in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @behnazh! Two minor comments follow…
This PR adds actionlint as a pre-commit hook to lint and check GitHub Actions workflows. The check runs using
make check-actionlint
.The new
actionlint
hook detects errors that were also addressed in #482 and #493, which had to be fixed here for the workflows to succeed.