fix(ci): add docs/source/ folder to the excludes of the Sync Upstream workflow #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenstroeger
force-pushed
the
minor-improvement-to-sync-upstream
branch
from
908ea3f to
1f02e34
Compare
jenstroeger
force-pushed
the
minor-improvement-to-sync-upstream
branch
from
1f02e34 to
3d69416
Compare
Yes, the new PR should technically supersede the previous one and close it.
It's better to use the CODEOWNERS feature in the downstream repo to add the relevant reviewers for the changed files. |
behnazh
approved these changes
Apr 2, 2023
This was referenced Apr 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Considering we have the previous version of the template:
python-package-template/.github/workflows/sync-with-upstream.yaml
Lines 49 to 50 in 6b337a3
would it make sense to check if a branch for that previous version exists, and close the PR and delete that now older branch? Or, if not, mark the older PR as a duplicate of the new PR?
The new branch that’s being opened should include all changes from that older branch 🤔
Also, should we add
--reviewerto the PR creation?