Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don’t build anew if a PR was simply edited, edited again #336

Merged
merged 6 commits into from
Oct 12, 2022
Merged

fix: don’t build anew if a PR was simply edited, edited again #336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
275d5cd
fix: don’t build anew if a PR was simply edited
jenstroeger Oct 4, 2022
78edf05
fix(ci): split PR workflow into two to handle events separately
jenstroeger Oct 8, 2022
1a4900e
fix: break the code 😈
jenstroeger Oct 9, 2022
a3af1c3
fix: unbreak the code 😇
jenstroeger Oct 9, 2022
e76f2cd
chore: remove comment because it's duplicated from build.yaml
jenstroeger Oct 9, 2022
bd8d88b
chore: change Action names
jenstroeger Oct 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions .github/workflows/pr-change-set.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
# This workflow checks and tests the package code, and it builds all package
# artifacts whenever there were changes to a pull request.

name: Check change set
on:
pull_request:
branches:
- main
- staging
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed shall we change the target branches to * to make sure the checks run on all pull requests?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR or a separate one?

types:
- opened
- reopened
- synchronize
permissions:
contents: read

jobs:
build:
uses: ./.github/workflows/build.yaml
permissions:
contents: read
9 changes: 1 addition & 8 deletions .github/workflows/pull-request.yaml → ...ub/workflows/pr-conventional-commits.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# tool to check the title of the PR and all commit messages of the branch
# which triggers this Action.

name: Pull Request
name: Check conventional commits
on:
pull_request:
branches:
Expand All @@ -19,7 +19,6 @@ permissions:

jobs:
conventional-commits:
name: Check PR title and commit messages
runs-on: ubuntu-latest
steps:

Expand Down Expand Up @@ -55,9 +54,3 @@ jobs:
PR_BASE_REF: ${{ github.event.pull_request.base.ref }}
PR_HEAD_REF: ${{ github.event.pull_request.head.ref }}
PR_HEAD_REPO_CLONE_URL: ${{ github.event.pull_request.head.repo.clone_url }}

build:
needs: conventional-commits
uses: ./.github/workflows/build.yaml
permissions:
contents: read