fix: don’t build anew if a PR was simply edited, edited again #336
Conversation
jenstroeger
force-pushed
the
dont-build-if-pr-edited
branch
from
e1fdcb7 to
8f48a95
Compare
|
Hm. I wonder if this is a good idea 🤔 Suppose we create a PR and the pull-request.yaml workflow fails because build.yaml fails; next, we make a comment on that same PR and now the workflow succeeds because it wouldn’t build again… |
jenstroeger
changed the title
|
Ok, run 3182767662 (6m 36s) was the initial run when we opened this PR which built the artifacts. Then we changed the PR title, thus triggering run 3182834503 (20s). Next, let’s change the title back. Adding comments to a PR doesn’t seem to trigger the workflow, though. |
jenstroeger
changed the title
How about creating two separate workflows for checking PR title and PR code changes to avoid the issue? |
jenstroeger
force-pushed
the
dont-build-if-pr-edited
branch
from
8f48a95 to
78edf05
Compare
Commit 78edf05. |
jenstroeger
changed the title
.github/workflows/pr-change-set.yaml
Outdated
| # This workflow checks and tests the package code, and it builds all package | ||
| # artifacts whenever there were changes to a pull request. | ||
|
|
||
| name: 'Pull Request: change set' |
There was a problem hiding this comment.
I think Pull Request in the name is not necessary because the trigger should appear in the workflow run.
How about "Check change set"?
There was a problem hiding this comment.
On the website the action run shows the name: of the Action:
with
How about "Check change set"?
Sure.
| @@ -3,7 +3,7 @@ | |||
| # tool to check the title of the PR and all commit messages of the branch | |||
| # which triggers this Action. | |||
|
|
|||
| name: Pull Request | |||
| name: 'Pull Request: conventional commits' | |||
There was a problem hiding this comment.
Same comment regarding the name.
| pull_request: | ||
| branches: | ||
| - main | ||
| - staging |
There was a problem hiding this comment.
As discussed shall we change the target branches to * to make sure the checks run on all pull requests?
There was a problem hiding this comment.
This PR or a separate one?
See also issue #330: there’s no need to run the build.yaml workflow if a PR was merely edited (i.e. no code was changed).