-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support PCT for multi-module Maven projects (II) #689
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Failed PCT against the multimodule
project branch. Note that #685 passes.
- Testing https://github.com/jenkinsci/workflow-cps-plugin/pull/689 bom#1899
- https://ci.jenkins.io/job/Tools/job/bom/job/PR-1899/2/consoleFull
What goal are you trying to achieve by continuing to dig into this?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The latest revision passes local PCT testing for me on the multimodule
project branch. Still not sure it was worth the effort.
Breaks the I suggest that you either figure out how to get your code to work on both PCT branches or that you accept my original submission (which does work on both branches), even if you consider it "undesirable". You can always switch back to your code once the PCT multimodule project has been integrated. |
Subsumes #685 but should allow jenkins-infra/repository-permissions-updater#3210 to be reverted, cleaning up technical debt from #612. Local testing seems fine using both a clean working copy and a clean local repo:
mvn clean test -Dtest=CpsDefaultGroovyMethodsTest