-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge groovy-cps into workflow-cps #612
Conversation
Sideporting tests for collect, each and collectEntries
…oovy-cps into closures-JENKINS-26481
…ge` at root level.
Fix uniqueSet test
…ing code generation to delegate to untranslated public methods when possible.
[JENKINS-44280] Test for overloading methods
[JENKINS-26481] Generate CpsDefaultGroovyMethods, invoke using GroovyCategorySupport
This reverts commit 0066f19.
See jenkinsci/plugin-compat-tester#383 for associated PCT changes. |
Rebuilding. (FTR, re-running a specific failed check from the left-hand sidebar on the checks page seems to work to trigger a new build, but the "re-run all checks" button from the top-right corner of the checks page does not seem to do anything, and you can only use the former if some check failed.) |
@jglick Do you know of any other examples of multi-module projects which skip deployment of a module that are able to publish incrementals? 1b01482 makes things work, but skipping installation for I'm not sure what other options we have. Maybe we could make |
Maybe activate the profile to skip installation when |
I am planning on merging this once the CI build passes. Then I'll merge master into #596 and release a new version of the plugin. I will work on merging master into existing open PRs, but I will probably not be able to get to all of them today. I'll also refile a few things from groovy-cps here today so I can archive it. |
Remove all content and update README to reference jenkinsci/workflow-cps-plugin#612
com.cloudbees:groovy-cps was merged into org.jenkins-ci.plugins.workflow:workflow-cps in November 2022 (see jenkinsci/workflow-cps-plugin#612).
com.cloudbees:groovy-cps was merged into org.jenkins-ci.plugins.workflow:workflow-cps in November 2022 (see jenkinsci/workflow-cps-plugin#612).
com.cloudbees:groovy-cps was merged into org.jenkins-ci.plugins.workflow:workflow-cps in November 2022 (see jenkinsci/workflow-cps-plugin#612).
This PR merges the entire history of https://github.com/cloudbees/groovy-cps into this plugin.
groovy-cps
is only supported in the context of Jenkins, and should only be used byworkflow-cps
. Keeping the library and plugin separate complicates maintenance and testing.The only interesting changes should be in 306d1ce (moves
workflow-cps
intoplugin
module), 96735ee (mergesgroovy-cps
into the repo), and any newer commits. Older commits are just the existing history ofgroovy-cps
.With this PR,
workflow-cps
can only be built using Java 11 or newer. The plugin will still run against Java 8, but thedgm-builder
module, which is only used when buildinggroovy-cps
, uses Java compiler APIs that were modified in Java 9 and so do not work with Java 8.TODO:
workflow-cps-parent
andgroovy-cps
to https://github.com/jenkins-infra/repository-permissions-updaterworkflow-cps
after this change