-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ErrorAction.findOrigin
failures due to ProxyException
#328
Merged
jglick
merged 11 commits into
jenkinsci:master
from
jglick:findOriginFromBodyExecutionCallback
May 16, 2024
Merged
ErrorAction.findOrigin
failures due to ProxyException
#328
jglick
merged 11 commits into
jenkinsci:master
from
jglick:findOriginFromBodyExecutionCallback
May 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge branch 'erroraction-id-proxyexception' into findOriginFromBodyExecutionCallback
dwnusbaum
reviewed
May 16, 2024
src/test/java/org/jenkinsci/plugins/workflow/actions/ErrorActionTest.java
Show resolved
Hide resolved
…an id initially, and later gets a distinct one
dwnusbaum
reviewed
May 16, 2024
src/main/java/org/jenkinsci/plugins/workflow/actions/ErrorAction.java
Outdated
Show resolved
Hide resolved
jglick
changed the title
May 16, 2024
ErrorActionTest.findOriginFromBodyExecutionCallback
ErrorAction.findOrigin
failures due to ProxyException
jglick
commented
May 16, 2024
src/main/java/org/jenkinsci/plugins/workflow/actions/ErrorAction.java
Outdated
Show resolved
Hide resolved
dwnusbaum
reviewed
May 16, 2024
src/test/java/org/jenkinsci/plugins/workflow/actions/ErrorActionTest.java
Outdated
Show resolved
Hide resolved
dwnusbaum
approved these changes
May 16, 2024
Co-authored-by: Devin Nusbaum <[email protected]>
jglick
commented
May 16, 2024
Comment on lines
+211
to
+212
var _t1 = t1; | ||
var _t2 = t2; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise javac complains about nonfinal variables in lambdas, which is irritating since the complaint includes usages of t1
and t2
in previous clauses which are returning without ever running this block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A test case that passes on Java 11 but fails on 17; fix inspired by #327.