Fix origin identification for unserializable exceptions #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwnusbaum
commented
May 16, 2024
| @@ -245,4 +247,15 @@ public static class X extends Exception { | |||
| assertNotNull(new ErrorAction(unserializable)); | |||
| assertNotNull(new ErrorAction(cyclic)); | |||
| } | |||
|
|
|||
| @Test public void findOriginOfRethrownUnserializableException() throws Throwable { | |||
There was a problem hiding this comment.
Fails without the changes in src/main because the FlowEndNode is identified as the origin instead.
src/main/java/org/jenkinsci/plugins/workflow/actions/ErrorAction.java
Outdated
Show resolved
Hide resolved
|
…but does not suffice according to #328. Digging into it. |
…uals if a ProxyException is involved
|
Oops, you are making changes here but I am working on changes in the more comprehensive test downstream, so this is all going to clash. |
|
It's fine, we can close this. |
jglick
added a commit
to jglick/workflow-api-plugin
that referenced
this pull request
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For exceptions which were not serializable, we previously only added
ErrorIdto theProxyExceptioncreated for serialization purposes. The original exception that was thrown up through the Pipeline's execution would have noErrorId, so each block/step that failed due to the exception would get a freshErrorId.Testing done
Submitter checklist