bump jenkins and pom version, add incrementals #59
Conversation
|
I need an adult (@timja @lemeurherve) to grant me super powers (write permisson) so I can be allowed to update jenkinsfile. Not like this changing big things in this PR pure maintenance. |
|
Replayed a build with manually replaced Jenkins version in the pipeline. |
|
/reviewer batmat |
Oh nice, it works even without the |
Co-authored-by: Tim Jacomb <[email protected]>
yup both works for user only :) |
|
need someone with super powers to rebuild, pretty please 😅 I guess we need a github-jenkins-comments-op. Or have Jenkins trust org members 😞 Or perhaps I can ask for ci.jenkins.io rebuild permission? 👏 |
Replayed 🙂
Could you open an issue in the help desk for that please? |
Done |
|
Can confirm this fixes the issues we are having in bom and jenkinsci/bom#1275 |
pom.xml
Outdated
| <relativePath /> | ||
| </parent> | ||
| <artifactId>variant</artifactId> | ||
| <version>1.5-SNAPSHOT</version> | ||
| <version>${revision}${changelist}</version> |
There was a problem hiding this comment.
Or we could go straight to CD, if the maintainer (whoever that is) approves.
There was a problem hiding this comment.
Or we could go straight to CD, if the maintainer (whoever that is) approves.
There was a problem hiding this comment.
already created PR for it: jenkins-infra/repository-permissions-updater#2669
Co-authored-by: Jesse Glick <[email protected]>
| <optional>true</optional> | ||
| <scope>test</scope> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.jenkins-ci.plugins</groupId> | ||
| <artifactId>credentials</artifactId> | ||
| <version>2.3.14</version> | ||
| <type>hpi</type> |
There was a problem hiding this comment.
It turns out that I also need this fix (the removal of <type>hpi</type> for my project, so I wish you a speedy merge and release!
|
@jetersen It turns out that in addition to your changes, I also need this change for my work on Maven HPI plugin/PCT: diff --git a/pom.xml b/pom.xml
index b0d5525..2b9803c 100644
--- a/pom.xml
+++ b/pom.xml
@@ -67,23 +67,11 @@
</dependency>
</dependencies>
- <build>
- <plugins>
- <plugin>
- <groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-surefire-plugin</artifactId>
- <configuration>
- <classpathDependencyExcludes>
- <classpathDependencyExcludes>org.jenkins-ci.plugins:beer</classpathDependencyExcludes>
- </classpathDependencyExcludes>
- </configuration>
- </plugin>
- </plugins>
- </build>
<properties>
<revision>1.5</revision>
<changelist>-SNAPSHOT</changelist>
<gitHubRepo>jenkinsci/${project.artifactId}-plugin</gitHubRepo>
<jenkins.version>2.319.3</jenkins.version>
+ <maven.test.dependency.excludes>org.jenkins-ci.plugins:beer</maven.test.dependency.excludes>
</properties>
</project>This will allow jenkinsci/maven-hpi-plugin#367 to extend these properties rather than clobbering them. Any chance you'd be willing to combine efforts and add the above to your PR? I realize that is asking a lot, so no problem if the answer is no - I can wait until after this is merged and then file a separate PR on top of it. But if you're willing to take on these extra low-risk changes, it could save some time. |
|
No problem, let me include it :) |
Co-authored-by: Basil Crow <[email protected]>
bumping jenkins version to remove sshd module to avoid cyclic dependencies.
unblocking jenkinsci/bom#1275
@batmat @jglick