Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable cd for variant and adopt variant #2669

Merged
merged 2 commits into from
Jul 26, 2022
Merged

Conversation

jetersen
Copy link
Contributor

Description

https://github.com/jenkinsci/variant-plugin

enable cd for variant plugin.
If you want @batmat we could also add me to the developer list.

Submitter checklist for adding or changing permissions

@batmat

Always

  • Add link to plugin/component Git repository in description above

Reviewer checklist (not for requesters!)

  • Check this if newly added person also needs to be given merge permission to the GitHub repo (please @ the people/person with their GitHub username in this issue as well). If needed, it can be done using an IRC Bot command
  • Check that the $pluginId Developers team has Admin permissions while granting the access.
  • In the case of plugin adoption, ensure that the Jenkins Jira default assignee is either removed or changed to the new maintainer.
  • If security contacts are changed (this includes add/remove), ping the security officer (currently @Wadeck) in this pull request. If an email contact is changed, wait for approval from the security officer.

There are IRC Bot commands for it

@jetersen jetersen requested a review from a team as a code owner July 22, 2022 16:33
@lemeurherve
Copy link
Member

/reviewer batmat

Copy link
Contributor

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(non-voting 👍)

@jetersen
Copy link
Contributor Author

Please consider this an adoption request if we do not hear from @batmat 😅

permissions/plugin-variant.yml Show resolved Hide resolved
@timja timja changed the title enable cd for variant enable cd for variant and adopt variant Jul 26, 2022
@batmat batmat merged commit 337df14 into jenkins-infra:master Jul 26, 2022
@jetersen jetersen deleted the patch-1 branch July 26, 2022 08:00
@basil
Copy link
Contributor

basil commented Jul 26, 2022

Thank you Baptiste!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants