forked from boozallen/jenkins-templating-engine
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reverse Library precedence during loading to prevent library overriding #132
Merged
steven-terrana
merged 10 commits into
jenkinsci:2.0
from
cokieffebah:reverse-library-tiers
Nov 23, 2020
Merged
Reverse Library precedence during loading to prevent library overriding #132
steven-terrana
merged 10 commits into
jenkinsci:2.0
from
cokieffebah:reverse-library-tiers
Nov 23, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steven-terrana
requested changes
Nov 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me - just needs updated documentation for the JTE block.
cokieffebah
commented
Nov 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added doc update for JTE block
steven-terrana
approved these changes
Nov 23, 2020
steven-terrana
changed the title
Reverse library tiers
Reverse Library precedence during loading to prevent library overriding
Nov 24, 2020
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
from #104 implemented library tier reversing by adding a jte{ reverse_library_resolution = Boolean } setting
(default) reverse_library_resolution = false -> library loading uses the current JTE loading
reverse_library_resolution = true -> goes in the reverse order of above
Description
How Has This Been Tested
Unit tests
Types of Changes
Checklist