Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverse Library precedence during loading to prevent library overriding #132

Merged
merged 10 commits into from
Nov 23, 2020

Conversation

cokieffebah
Copy link

@cokieffebah cokieffebah commented Nov 19, 2020

PR Details

from #104 implemented library tier reversing by adding a jte{ reverse_library_resolution = Boolean } setting
(default) reverse_library_resolution = false -> library loading uses the current JTE loading
reverse_library_resolution = true -> goes in the reverse order of above

Description

How Has This Been Tested

Unit tests

Types of Changes

  • Added Unit Testing
  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have added the appropriate label for this PR
  • If necessary, I have updated the documentation accordingly.
  • All new and existing tests passed.

Copy link

@steven-terrana steven-terrana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me - just needs updated documentation for the JTE block.

@cokieffebah cokieffebah self-assigned this Nov 19, 2020
Copy link
Author

@cokieffebah cokieffebah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added doc update for JTE block

@steven-terrana steven-terrana merged commit c67ce3c into jenkinsci:2.0 Nov 23, 2020
@steven-terrana steven-terrana changed the title Reverse library tiers Reverse Library precedence during loading to prevent library overriding Nov 24, 2020
@cokieffebah cokieffebah deleted the reverse-library-tiers branch January 7, 2021 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants