Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow config to reverse library precedence #104

Conversation

linead
Copy link

@linead linead commented Jul 24, 2020

PR Details

Added checkbox in global config to allow disabling of libraries being loaded at a more granular level

Description

How Has This Been Tested

Added test as well as manual verification

Types of Changes

  • Added Unit Testing
  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have added the appropriate label for this PR
  • If necessary, I have updated the documentation accordingly.
  • All new and existing tests passed.

@steven-terrana
Copy link

Thank you @linead! I'll test this out today but the code looks good so far

@cokieffebah
Copy link

cokieffebah commented Aug 21, 2020

Hi @linead We are working on a 2.0 version and we have not forgotten about this PR.
Full disclosure, we think the configuration is best done in the pipeline_config.groovy. We have made various changes in 2.0 and we will probably ask you to submit a new PR against the 2.0 branch after our affecting changes are added to 2.0.

Sorry for the inconvenience/delay, we will try to give you the changes needed to complete the intent of this PR.

@linead
Copy link
Author

linead commented Aug 22, 2020

All good @cokieffebah - thanks for the update

@steven-terrana
Copy link

This feature has been implemented in #132 into the new 2.0 code base.

as such, closing this PR.

We'll make sure you get the credit in the changelog @linead! We appreciate your patience on this  🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants