Add Selector support #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
|
Cannot assign myself as a reviewer, but I will try to review it next week |
oleg-nenashev
approved these changes
Mar 26, 2018
There was a problem hiding this comment.
I have tested it locally and it works well. I'd guess minor Binary compatibility changes are not a problem for this Lib/CLI, hence 🐝
I also tested it with jenkinsci/file-leak-detector-plugin#2 from @denisj44. It seems to work well though I had some issues with building the plugin on Java 8
|
@reviewbybees done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on top of #33 to pick up useful pom changes and validate against the extra tests. I am happy to submit a PR against master with only my commits if desired.
This is not going to be completely accurate, as what file descriptors are opened by a selector vary from platform to platform, but is simpler than transforming all of the different native classes to track each descriptor separately. For example, EPollSelectorImpl on Linux will open 2 pipes and an anonymous inode for event polling, but this PR only tracks it as a single descriptor.
This seems ok to me, since those file descriptors will be opened and closed together anyway (barring any JDK bugs), and once you know that you are leaking
Selectors you can figure out exactly what file descriptors are being created on your platform for eachSelector.@reviewbybees