Update to file-leak-detector:1.11 to detect pipe and selector leaks #3
Conversation
.gitignore
Outdated
| @@ -1,2 +1,4 @@ | |||
| target | |||
| work | |||
| .idea | |||
There was a problem hiding this comment.
I don't think idea editor specific files needs to be added.
There was a problem hiding this comment.
I think you added it originally in 504dc08 😄
I will go ahead and remove it, but for what it's worth .idea and other IntelliJ/Eclipse files are added to .gitignore by default for any plugins using the maven archetype generator: https://github.com/jenkinsci/archetypes/blob/master/empty-plugin/src/main/resources/archetype-resources/.gitignore. We could follow up with a separate PR to add all of those entries to .gitignore if desired.
| */ | ||
| private void activateFileLeakDetector() throws Exception { | ||
| FileHandleDump fileHandleDump = ManagementLink.all().get(FileHandleDump.class); | ||
| fileHandleDump.doActivate(""); |
There was a problem hiding this comment.
Good catch. I'll investigate to see whether we can fix it here or if the library itself doesn't work on Windows.
There was a problem hiding this comment.
I really have no idea. You can always
buildPlugin(platforms: ['linux'])if it is known not to work on Windows.
There was a problem hiding this comment.
Updating to JNR fixed the main issue, but pipes aren't detected correctly on Windows by the library, so I've ignored that test on Windows for now. See jenkinsci/lib-file-leak-detector#36.
Subsumes #2.
Updates the parent pom and specifies explicit Jenkins and Java versions, pulls in jenkinsci/lib-file-leak-detector#34 which adds support for detecting
Pipes,Selectors, and files opened viaFileChannel, and adds some basic tests.@reviewbybees