[JEP-207, JEP-212] - Address comments from @jglick #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- [x] - LoggingMethod and LogBrowser have been merged into LogStorage - [x] - Seperate implementations are now introduced in External Logging API instead - [x] - Per-step log browsing has been removed from the core (see Reasoning) - [x] - Encoding requirements have been explicitly documented
|
It may take me a few days to get to this as I work on the JEP-210 reference implementation. |
jglick
approved these changes
Aug 10, 2018
|
Yes, there will be more follow-up patches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change aligns the JEP with the new implementation in jenkinsci/jenkins#3575
Implementations:
Also CC @carlossg who is a BDFL delegate in JEP-212