Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

External Logging API: Align with new Core version, fix Findbugs #2

Merged
merged 10 commits into from
Jan 3, 2019
Merged

External Logging API: Align with new Core version, fix Findbugs #2

merged 10 commits into from
Jan 3, 2019

Conversation

oleg-nenashev
Copy link
Member

@oleg-nenashev oleg-nenashev commented Aug 3, 2018 •
edited
Loading

This is a new PR, which aligns compatibility with jenkinsci/jenkins#3575

  • - Jenkins core uses a single pluggable class: LogStorage
  • - The plugin itself splits the implementation to ExternalLogBrowser and ExternalLoggingMethod

@reviewbybees @carlossg @jglick

@oleg-nenashev
Copy link
Member Author

It somehow picked the wrong core build...

@oleg-nenashev
Copy link
Member Author

Yeah, it takes code from jenkinsci/jenkins#3575 (there were to deployments). I will bite the bullet and just refactor it, can be reverted later

This was referenced Aug 6, 2018
Open
Merged
jglick
jglick reviewed Aug 10, 2018
View reviewed changes
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just merge it if that is helpful. I doubt anyone reviewed every line of the original anyway.

pom.xml
@@ -20,7 +20,9 @@
<properties>
<revision>1.0-alpha-1</revision>
<changelist>-SNAPSHOT</changelist>
<jenkins.version>2.135-rc15088.42aa6febbbed</jenkins.version>
<!--TODO: replace by incrementals (JENKINS-52873) -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not take more than a moment right?

src/main/java/io/jenkins/plugins/extlogging/api/Event.java
@@ -15,6 +15,7 @@
final long timestamp;
final long id;

//TODO:Consider <String,String> so that Key-Value storages could be quickly implemented
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please; I do not think implementations can be expected to take arbitrary Java objects.

@oleg-nenashev
Copy link
Member Author

Just merge it if that is helpful. I doubt anyone reviewed every line of the original anyway.

Agreed

@oleg-nenashev oleg-nenashev merged commit 5d89112 into jenkinsci:referenceImpl Jan 3, 2019
@darxriggs
Copy link

Hi @oleg-nenashev and @jglick, the Jenkins incrementals version cannot be resolved - see https://ci.jenkins.io/job/Plugins/job/external-logging-api-plugin/job/referenceImpl/. Can you tell what this version was about and why it is not available at https://repo.jenkins-ci.org/incrementals/org/jenkins-ci/main/jenkins-core/?

@oleg-nenashev
Copy link
Member Author

See the referenced upstream PR in the description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jglick jglick jglick left review comments

@carlossg carlossg Awaiting requested review from carlossg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oleg-nenashev @darxriggs @jglick