[JENKINS-66930] remove unsafe classes copied from Apache Ant which have been deprecated in Oct 2019

[olamy]

Signed-off-by: Olivier Lamy [email protected]

See JENKINS-66930.

Proposed changelog entries

• Remove deprecated, unsafe classes previously copied from Apache Ant. Docker Slaves plugin is incompatible with this change.

Proposed upgrade guidelines

In case your plugin use those classes, just migrate to the org.apache.ant package

Submitter checklist

• (If applicable) Jira issue is well described
• Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change). Examples
  • Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
• Appropriate autotests or explanation to why this change has no tests
• For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@mention

Maintainer checklist

Before the changes are marked as ready-for-merge:

• There are at least 2 approvals for the pull request and no outstanding requests for change
• Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
• Changelog entries in the PR title and/or Proposed changelog entries are correct
• Proper changelog labels are set so that the changelog can be generated automatically
• If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
• If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

[StefanSpieker]

I tried to remove that before, as you can see here: #4272 There are still two plugins which use it:
jenkinsci/copy-to-slave-plugin#11
jenkinsci/fstrigger-plugin#4

The fstrigger got merged and is already published. We should put this to the upgrade guide. I don't know how often the copy to slave plugin is used.

[daniel-beck]

jenkinsci/copy-to-slave-plugin#11

Ignore, distribution is suspended (and has been for a long time) so we can pretend it doesn't exist.

[daniel-beck]

jenkinsci/docker-slaves-plugin@71ed3c8 remains unreleased.

It's now safe to remove them .

Based on what data is this asserted? Please show your work.

[oleg-nenashev]

I am -1 for the change in the current state. hudson.org.apache.tools.tar.TarInputStream is used in https://github.com/jenkinsci/copy-to-slave-plugin/blob/c0ea34f47941b1647fd05ea31eb69779ce53fab3/src/main/java/com/michelin/cio/hudson/plugins/copytoslave/MyFilePath.java. Even if the class is deprecated, I believe we need to check and cleanup usages in actively used plugins.

[daniel-beck]

is used in https://github.com/jenkinsci/copy-to-slave-plugin/blob/c0ea34f47941b1647fd05ea31eb69779ce53fab3/src/main/java/com/michelin/cio/hudson/plugins/copytoslave/MyFilePath.java

https://plugins.jenkins.io/copy-to-slave/

The plugin hasn't been distributed for 3.5 years.

[timja]

Shall we archive the github repo?

[basil]

hudson.org.apache.tools.tar.TarOutputStream is still used in the currently released version of Docker Slaves. I don't feel strongly that this plugin should remain supported, but if we do decide to drop support for it I think this should be mentioned in the release notes and a deprecation notice added to the plugin in the update center.

[olamy]

I know we only need someone to release docker slave plugin.
if we can find someone.... @darxriggs maybe?
but this plugin is not very active anymore https://github.com/jenkinsci/docker-slaves-plugin/commits/master

[darxriggs]

I am not the maintainer of the docker-slaves-plugin. Nevertheless, I would also like to see my cleanups of it being released.

[olamy]

let's hope someone release the docker-slave-plugin.....
maybe we should archive it if no one maintain it.

[olamy]

answer from maintainer: jenkinsci/docker-slaves-plugin@71ed3c8#commitcomment-58330874

[daniel-beck]

answer from maintainer

Nicolas stepped down 2 years ago. At the moment we still consider @ydubreuil to be its (only) maintainer, but he hasn't been around in a while.

[olamy]

adding on-hold to wait for release of the plugin....

[daniel-beck]

I don't think we need to wait, we just need to document that there's no compatible release for docker-slaves.

[jtnord]

I agree with @daniel-beck the code in docker-slaves-plugin has been merged and waiting for release for over 2 years, if that is not long enough what is the expected minimum amount of time?

[timja]

added to changelog, feel free to re-word

[timja]

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

[daniel-beck]

is used in https://github.com/jenkinsci/copy-to-slave-plugin/blob/c0ea34f47941b1647fd05ea31eb69779ce53fab3/src/main/java/com/michelin/cio/hudson/plugins/copytoslave/MyFilePath.java

https://plugins.jenkins.io/copy-to-slave/

The plugin hasn't been distributed for 3.5 years.

https://groups.google.com/g/jenkinsci-users/c/fVojVq2Mas0/m/tyW76wgoAwAJ 🙃

[daniel-beck]

daniel-beck added a commit that referenced this pull request

Misclick, I have no intention of reverting.