Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark TarOutputStream as restricted #4272

Merged
merged 4 commits into from
Oct 10, 2019

Conversation

StefanSpieker
Copy link
Contributor

I'm pretty sure that it is not used anymore, because the search just shows no usage at all:
https://github.com/search?q=org%3Ajenkinsci+TarOutputStream&type=Code

Proposed changelog entries

  • Internal: Removed deprecated TarOutputStream

Submitter checklist

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is being used in of CloudBees proprietary plugins. CC @jtnord @amuniz .
Unfortunately, just searching GitHub is not always enough, because there are hundreds(thousands?) of private-source plugins created by Jenkins user companies and vendors

@daniel-beck
Copy link
Member

Also, unfortunately we still distribute some plugins outside the jenkinsci org from several years ago.

For those, https://github.com/jenkins-infra/deprecated-usage-in-plugins works better as it downloads all currently distributed plugins and searches for uses of classes from a list of names.

@oleg-nenashev
Copy link
Member

Putting @Restricted(DoNotUse.class) could be a good option once jenkinsci/lib-access-modifier#17 is released. @Restricted(NoExternalUse.class) can be used as a workaround to highlight deprecation for plugin maintainers. PCT will not fail, so why not?

@StefanSpieker
Copy link
Contributor Author

Ok, that is a good idea. I also added this annotation to the TarInputStream and already created PRs for plugins which still use this class:
jenkinsci/copy-to-slave-plugin#11
jenkinsci/fstrigger-plugin#4

@daniel-beck
Copy link
Member

daniel-beck commented Oct 6, 2019

Probably the most pragmatic approach.

@RestrictedSince might be helpful too.

@oleg-nenashev
Copy link
Member

+1 for @RestrictedSince. We can safely assume it lands in the next weekly (2.200)

@StefanSpieker
Copy link
Contributor Author

I added the @RestrictedSince("2.200") as suggested

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@daniel-beck daniel-beck changed the title removed deprecated TarOutputStream Mark TarOutputStream as restricted Oct 7, 2019
@oleg-nenashev oleg-nenashev requested a review from a team October 9, 2019 21:56
@oleg-nenashev
Copy link
Member

I plan to merge it tomorrow if no negative feedback

@oleg-nenashev oleg-nenashev added ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback developer Changes which impact plugin developers and removed internal labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer Changes which impact plugin developers ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants