-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-42556] Improved logging for Queue #2791
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -728,7 +728,11 @@ public boolean cancel(Task p) { | |
} | ||
|
||
private void updateSnapshot() { | ||
snapshot = new Snapshot(waitingList, blockedProjects, buildables, pendings); | ||
Snapshot revised = new Snapshot(waitingList, blockedProjects, buildables, pendings); | ||
if (LOGGER.isLoggable(Level.FINEST)) { | ||
LOGGER.log(Level.FINEST, "{0} → {1}; leftItems={2}", new Object[] {snapshot, revised, leftItems.asMap()}); | ||
} | ||
snapshot = revised; | ||
} | ||
|
||
public boolean cancel(Item item) { | ||
|
@@ -1443,9 +1447,11 @@ public void maintain() { | |
} | ||
// pending -> buildable | ||
for (BuildableItem p: lostPendings) { | ||
LOGGER.log(Level.FINE, | ||
if (LOGGER.isLoggable(Level.FINE)) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Avoid computing There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Note that there are more cases of this optimization that could be done; I just picked some sample cases. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
LOGGER.log(Level.FINE, | ||
"BuildableItem {0}: pending -> buildable as the assigned executor disappeared", | ||
p.task.getFullDisplayName()); | ||
} | ||
p.isPending = false; | ||
pendings.remove(p); | ||
makeBuildable(p); // TODO whatever this is for, the return value is being ignored, so this does nothing at all | ||
|
@@ -1464,7 +1470,7 @@ public void maintain() { | |
Collections.sort(blockedItems, QueueSorter.DEFAULT_BLOCKED_ITEM_COMPARATOR); | ||
} | ||
for (BlockedItem p : blockedItems) { | ||
String taskDisplayName = p.task.getFullDisplayName(); | ||
String taskDisplayName = LOGGER.isLoggable(Level.FINEST) ? p.task.getFullDisplayName() : null; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
LOGGER.log(Level.FINEST, "Current blocked item: {0}", taskDisplayName); | ||
if (!isBuildBlocked(p) && allowNewBuildableTask(p.task)) { | ||
LOGGER.log(Level.FINEST, | ||
|
@@ -1499,7 +1505,7 @@ public void maintain() { | |
if (!isBuildBlocked(top) && allowNewBuildableTask(p)) { | ||
// ready to be executed immediately | ||
Runnable r = makeBuildable(new BuildableItem(top)); | ||
String topTaskDisplayName = top.task.getFullDisplayName(); | ||
String topTaskDisplayName = LOGGER.isLoggable(Level.FINEST) ? top.task.getFullDisplayName() : null; | ||
if (r != null) { | ||
LOGGER.log(Level.FINEST, "Executing runnable {0}", topTaskDisplayName); | ||
r.run(); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally handy to know when the state of the queue changes, for whatever reason.