[JENKINS-42556] Improved logging for Queue #2791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jglick
commented
Mar 9, 2017
| snapshot = new Snapshot(waitingList, blockedProjects, buildables, pendings); | ||
| Snapshot revised = new Snapshot(waitingList, blockedProjects, buildables, pendings); | ||
| if (LOGGER.isLoggable(Level.FINEST)) { | ||
| LOGGER.log(Level.FINEST, "{0} → {1}; leftItems={2}", new Object[] {snapshot, revised, leftItems.asMap()}); |
There was a problem hiding this comment.
Generally handy to know when the state of the queue changes, for whatever reason.
| @@ -1443,9 +1447,11 @@ public void maintain() { | |||
| } | |||
| // pending -> buildable | |||
| for (BuildableItem p: lostPendings) { | |||
| LOGGER.log(Level.FINE, | |||
| if (LOGGER.isLoggable(Level.FINE)) { | |||
There was a problem hiding this comment.
Avoid computing getFullDisplayName if we do not have to.
There was a problem hiding this comment.
Note that there are more cases of this optimization that could be done; I just picked some sample cases.
| @@ -1464,7 +1470,7 @@ public void maintain() { | |||
| Collections.sort(blockedItems, QueueSorter.DEFAULT_BLOCKED_ITEM_COMPARATOR); | |||
| } | |||
| for (BlockedItem p : blockedItems) { | |||
| String taskDisplayName = p.task.getFullDisplayName(); | |||
| String taskDisplayName = LOGGER.isLoggable(Level.FINEST) ? p.task.getFullDisplayName() : null; | |||
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
aheritier
approved these changes
Mar 9, 2017
|
🐝 |
oleg-nenashev
added
needs-more-reviews
|
@reviewbybees done. I consider merging it since any performance optimization of the queue is useful |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logging improvements useful in the course of developing a fix for JENKINS-42556.
@reviewbybees