Don't set default for job-specific messages #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was wondering why I kept getting those comments. I think there is a better way to satisfy both worlds. |
|
Just remove the two if statements instead, while leaving the replace macros |
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
|
@DavidTanner Done. |
|
Also fixed indenting, hope you don't mind. |
DavidTanner
added a commit
that referenced
this pull request
Oct 9, 2014
Don't set default for job-specific messages
nosmo
pushed a commit
to nosmo/ghprb-plugin
that referenced
this pull request
Dec 12, 2018
Don't set default for job-specific messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After these were added, there was no way to turn off commenting.
We don't need to set the default for job-specific status messages, since it's already set at the plugin level.