Skip to content

Commit

Permalink
Merge pull request #55 from jsm/fix_commenting
Browse files Browse the repository at this point in the history
Don't set default for job-specific messages
  • Loading branch information
DavidTanner committed Oct 9, 2014
2 parents 49c2f62 + 3875a5f commit f997416
Showing 1 changed file with 4 additions and 13 deletions.
17 changes: 4 additions & 13 deletions src/main/java/org/jenkinsci/plugins/ghprb/GhprbTrigger.java
Original file line number Diff line number Diff line change
Expand Up @@ -527,23 +527,14 @@ public String getUnstableAs() {
}

public String getMsgSuccess(AbstractBuild<?, ?> build) {
String msg = msgSuccess;
if (msg == null) {
msg = "Test PASSed.";
}

msg = Ghprb.replaceMacros(build, msg);
String msg = msgSuccess;
msg = Ghprb.replaceMacros(build, msg);
return msg;
}

public String getMsgFailure(AbstractBuild<?, ?> build) {
String msg = msgFailure;
if (msg == null) {
msg = "Test FAILed.";
}

msg = Ghprb.replaceMacros(build, msg);

String msg = msgFailure;
msg = Ghprb.replaceMacros(build, msg);
return msg;
}

Expand Down

0 comments on commit f997416

Please sign in to comment.