Migrate to Jakarta Mail #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
basil
force-pushed
the
javamail-migrate
branch
3 times, most recently
from
8a85579 to
e14b09c
Compare
basil
force-pushed
the
javamail-migrate
branch
from
e14b09c to
4acbd4e
Compare
jglick
reviewed
Jul 20, 2022
| filtered = recipients.findAll { addr -> addr.toString().endsWith('@example.com') } | ||
| msg.setRecipients(javax.mail.Message.RecipientType.TO, filtered as javax.mail.Address[]) | ||
| msg.setRecipients(jakarta.mail.Message.RecipientType.TO, filtered as jakarta.mail.Address[]) |
There was a problem hiding this comment.
As an aside to the plugin maintainer (if there still is one), this seems like a very dangerous design decision. On top of the other problems with in-process scripting, user-exposed methods (typically @Whitelisted) should avoid referring to types outside the Java Platform in their signatures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downstream of #335, #336, and jenkinsci/jenkins#6165. Bumps the baseline to one containing jenkinsci/jenkins#6165 and migrates to Jakarta Mail.