Adapt to Jakarta Mail migration #1280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basil
added
dependencies
timja
approved these changes
Jul 19, 2022
jglick
approved these changes
Jul 19, 2022
…execute (default) on project sample: Managed plugin dependency io.jenkins.plugins:jakarta-activation-api not listed in test classpath of sample plugin -> [Help 1]
…execute (default) on project sample: Managed plugin dependency io.jenkins.plugins:jakarta-mail-api not listed in test classpath of sample plugin -> [Help 1]
|
I am not exactly sure what you are force-pushing here—that breaks the incremental review function of PRs. It should not be necessary if the PR will be squash-merged anyway, right? (Except in weird cases like when you accidentally merged in the wrong base branch and filled the commit list with junk.) |
jglick
approved these changes
Jul 19, 2022
You do not need to be
Already aware of that |
|
Should we do a release of this before dropping for 2.289.x and 2.303.x? |
|
No strong preference, but if we do, then I'd like to get #1288 in first because that builds on top of this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapting to: