Modernize UI

[timja]

• Use context specific sidepanel
• Remove sidepanel on main credentials page
• Display store specific names rather than Jenkins for all of them on view credentials page
• Remove norefresh from views
• Maintain manage in url bar so that breadcrumbs work correctly

Note: screenshots taken on 2.366, on 2.361 the one-column layouts will be a bit wider and not look quite as good

	Before	After
View Credentials
View domain (one-column)
View domain (domain modifiable)
View store (domain not modifiable)
View store (domain modifiable)
Add domain

TODO:

• Remove some duplication between ViewCredentialsAction and CredentialsStoreAction~
• Look at fixing JENKINS-68791 probably with Expose org.jenkins.ui.symbol.Symbol jenkins#6659 - will do separately
• Review folder plugin with its credentials provider
• Before and after screenshots

[daniel-beck]

Unused

[daniel-beck]

Looks reasonable overall. Especially thanks for taking care of the confusing sidepanels :)

[timja]

Moved code from CredentialsStoreAction

[janfaracik]

Looks good to me!

---

For this page, how would you feel about moving the 'Add domain' into the app bar and making it a primary button? (like the System Log page)

[timja]

Yep will try it, it was looking quite weird with a single item there

[timja]

mind taking another look? I'll update screenshots later on

Edit: Screenshots updated

[timja]

@jenkinsci/credentials-plugin-developers possible for a review please?

[jtnord]

Thanks TIm,

I tested this mostly on 2.361.1

when I go to "add a credential" I get a page (2 column) that seems out of place with the new design

Given I am in the "add credential" of a current domain" should the "confgure domain" delete/domain and "add credential" show up here? (even add credential which would just take me back to the same URL?)

--

I believe delete (or destructive action) buttons should still have a danger class (ie be red?). the screenshot in the description does - but it does not for me locally (chrome, windows)

domain overview page.

--

I am also a bit unsure how this fits into the "new way" as Jenkins still has side bars for "global tool config", "manage logs", "configure Global secruity" "manage nodes and cloud" etc. yet not for "manage credentials". this seems a bit jarring.

noticed things are being removed in the weeklies so this would be addressed by the time the next LTS rolls around.

--

When viewing Folder credentials there is no obvious way to guide you where to go. (yes the existing design is shitty) but there was a subtask under the credentials task which highlighted the "folder"

--

running a subset of ATHs to see if there are any impacts there

[jtnord]

something is definatly wrong with the delete button, but see more feedback above

(is red with 2.688 but not with the LTS).

[timja]

all the feedback should be addressed

the class was renamed in 2.364 I could add both, but some of the pages look a bit funny on a one-column layout without other changes in 2.364 so I think better to just raise the baseline to that.

When viewing Folder credentials there is no obvious way to guide you where to go. (yes the existing design is shitty) but there was a subtask under the credentials task which highlighted the "folder"

I have potential future plans to remove the stores from that page, add a search bar and create a new create credential experience where you can choose the store / type / context in a nicer page.

but I think out of scope of this PR and this should be good enough for now?

[jtnord]

the class was renamed in 2.364 I could add both, but some of the pages look a bit funny on a one-column layout without other changes in 2.364 so I think better to just raise the baseline to that.

I'm a bit hesitant on bumping the baseline this early in the LTS cycle. (There's some fixes still needed to be written for the icon change) and I would like to avoid branching if possible.

Additionally I thought the pages whilst not perfect in the LTS where still an improvement over the previous code.

Would you be against dropping the version requirement to the LTS and adding the old class name in addition?

[timja]

Done

[jtnord]

Thanks @timja

[ite-klass]

A more descriptive PR title would have been helpful for the release changelog

[timja]

A more descriptive PR title would have been helpful for the release changelog

see the PR description, or feel free to suggest a new one.

[ite-klass]

Modernize UI would clarify it is about user interface / presentation changes