-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize UI #364
Modernize UI #364
Conversation
3757961
to
4012ce7
Compare
src/main/resources/com/cloudbees/plugins/credentials/ViewCredentialsAction/index.properties
Show resolved
Hide resolved
@@ -58,6 +58,7 @@ | |||
import jenkins.model.ModelObjectWithContextMenu; | |||
import jenkins.model.TransientActionFactory; | |||
import org.acegisecurity.Authentication; | |||
import org.apache.commons.lang.StringUtils; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unused
Looks reasonable overall. Especially thanks for taking care of the confusing sidepanels :) |
dcdc430
to
87e6e32
Compare
* Resolves a display name from the Store | ||
* @return the display name | ||
*/ | ||
public String getDisplayName() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved code from CredentialsStoreAction
Yep will try it, it was looking quite weird with a single item there |
mind taking another look? I'll update screenshots later on Edit: Screenshots updated |
...resources/com/cloudbees/plugins/credentials/CredentialsStoreAction/DomainWrapper/index.jelly
Outdated
Show resolved
Hide resolved
…lsStoreAction/DomainWrapper/index.jelly Co-authored-by: Alexander Brandes <[email protected]>
@jenkinsci/credentials-plugin-developers possible for a review please? |
Thanks TIm, I tested this mostly on 2.361.1 when I go to "add a credential" I get a page (2 column) that seems out of place with the new design Given I am in the "add credential" of a current domain" should the "confgure domain" delete/domain and "add credential" show up here? (even add credential which would just take me back to the same URL?) -- I believe delete (or destructive action) buttons should still have a domain overview page. --
noticed things are being removed in the weeklies so this would be addressed by the time the next LTS rolls around. -- When viewing Folder credentials there is no obvious way to guide you where to go. (yes the existing design is shitty) but there was a subtask under the credentials task which highlighted the "folder" -- running a subset of ATHs to see if there are any impacts there |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
something is definatly wrong with the delete button, but see more feedback above
(is red with 2.688 but not with the LTS).
all the feedback should be addressed the class was renamed in 2.364 I could add both, but some of the pages look a bit funny on a one-column layout without other changes in 2.364 so I think better to just raise the baseline to that.
I have potential future plans to remove the stores from that page, add a search bar and create a new create credential experience where you can choose the store / type / context in a nicer page. but I think out of scope of this PR and this should be good enough for now? |
I'm a bit hesitant on bumping the baseline this early in the LTS cycle. (There's some fixes still needed to be written for the icon change) and I would like to avoid branching if possible. Additionally I thought the pages whilst not perfect in the LTS where still an improvement over the previous code. Would you be against dropping the version requirement to the LTS and adding the old class name in addition? |
Done |
Thanks @timja |
A more descriptive PR title would have been helpful for the release changelog |
see the PR description, or feel free to suggest a new one. |
Modernize UI would clarify it is about user interface / presentation changes |
Jenkins
for all of them on view credentials pagenorefresh
from viewsmanage
in url bar so that breadcrumbs work correctlyNote: screenshots taken on 2.366, on 2.361 the
one-column
layouts will be a bit wider and not look quite as goodTODO:
ViewCredentialsAction
andCredentialsStoreAction
~Look at fixing JENKINS-68791 probably with Expose- will do separatelyorg.jenkins.ui.symbol.Symbol
jenkins#6659