Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move app-bar to main panel #366

Merged
merged 4 commits into from
Nov 9, 2022

Conversation

timja
Copy link
Member

@timja timja commented Sep 8, 2022

downstream of jenkinsci/jenkins#7051 (released in 2.374)

App-bar has received a new feature to allow it to be in the sidepanel, it's now required to place it in the section you want it displayed.

Currently there's a minor UI issue with credentials plugin on 2.374 without this as the headings will be in the wrong place right now

@timja timja marked this pull request as ready for review October 22, 2022 11:53
@timja timja requested a review from a team October 22, 2022 11:53
@timja timja changed the title Move app-bar to main panel (branched from modernise PR) Move app-bar to main panel Oct 24, 2022
@jtnord jtnord enabled auto-merge November 9, 2022 16:01
@jtnord jtnord added the chore label Nov 9, 2022
@jtnord jtnord mentioned this pull request Nov 9, 2022
@jtnord jtnord merged commit 91d949d into jenkinsci:master Nov 9, 2022
@timja timja deleted the app-bar-side-panel-v2-off-rework branch November 9, 2022 21:13
@jimklimov
Copy link

hindsight-nit: isn't "update to LTS branch" a misnomer when LTS is 2.361.4 and update is to 2.375?
As a result, rebuilds can't be installed to the currently GA LTS version... (locally, reverting the numbers seems to have worked)

@timja
Copy link
Member Author

timja commented Nov 22, 2022

You don’t need this on old versions. The LTS version reference is for the next line being released on the 30th

@jimklimov
Copy link

i needed current plugin on older version (current LTS)
well, sort of needed - to deploy my PR based against master

@timja
Copy link
Member Author

timja commented Nov 23, 2022

i needed current plugin on older version (current LTS)
well, sort of needed - to deploy my PR based against master

Right best to either adjust locally and build or create a separate PR that’s not for merge that has the changes necessary to run on that version

@jimklimov
Copy link

(Ab)using PRs to build the incremental version? :)

Or just to rebase PRed changes over older baseline? (the latter feels clumsy, in case the PR needs to evolve so lots of dual-cherrypicking involved).

Anyhow, originally it was just a nit about "update to LTS branch" not being really that at that moment, making the result not usable for currently published LTS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants