[JENKINS-57775][JENKINS-62780] Handle PRs from/to non existing src/dest #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitwiseman
reviewed
Jun 24, 2020
There was a problem hiding this comment.
Looks like you ran into some spotbugs issues.
When testing against Bitbucket Server (7.2.1), I could not reproduce such scenario:
- PR opened from deleted source branch or forked are automatically declined.
- Bitbucket Server does not let me delete a destination branch if there is an open PR against it: "You cannot delete this branch since it has at least one open pull request associated with it"
Since you're controlling/mocking the responses, you could create a custom one that has these behaviors right?
Regardless of whether you can get the server to do it currently, it seems like something that should be tested to ensure it is handled.
| if(this.branch != null) { | ||
| // redound available the informations into impl objects | ||
| if(this.branch != null && this.commit != null) { | ||
| // redound available the information into impl objects |
There was a problem hiding this comment.
@bitwiseman I want heavy remember to you branch-api-plugin#160
...dbees/jenkins/plugins/bitbucket/client/pullrequest/BitbucketPullRequestValueDestination.java
Outdated
Show resolved
Hide resolved
I am not sure that those behaviors are even possible from Bitbucket Server. |
bitwiseman
force-pushed
the
bugfix/JENKINS-62780
branch
from
d6759dc
to
f7b3a48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix NPEs caused by deleted source and destination branch or repository of PRs.
Tested the different scenario against Bitbucket Cloud and confirmed that:
source.repositorycan benull(deleted source repository)source.commitcan benull(deleted source repository)destination.commitcan benull(deleted destination branch)I haven't been able to reproduce a nullable
source.branchordestination.branch.When testing against Bitbucket Server (7.2.1), I could not reproduce such scenario:
Your checklist for this pull request