[JENKINS-54401] NPE when parsing scm git revision date on PR branches

[nfalco79]

Fix the retrieve of the commit informations for a HEAD source of a pullrequest branch.

This is a WIP because there are yet possible issues on commit informations when required by SCM traits.
The traits that decorate the source context with filters or prefilter are involved during the process of request before the revision factory is called. This means that no information will be available for a PR unless already present in the original response from bitbucket. Actually the client APIs need to be refactored to support callable that allow extra HTTP request in case some data are getted.
For example bitbucket for the pullrequests sends for both source and destination only the hash of head commit and the branch name. Actually BitbucketPullRequestValueDestination has the following fileds:

• BitbucketCloudBranch that represents the full info for a branch and all HEAD commit info but only the branch name is available in a PR request
• BitbucketCloudCommit that represent the full info of a commit revision but only the hash is available in a PR request
  it's easier point to a null value everywhere in the code.

In my opinion, for the future, could be a good idea move the client API code in a separate plugin Bitbucket Client API so can be shared across jenkins plugins.

[nfalco79]

@Casz the fix is completed, I had try to cover all possible scenarios where commit informations are requested (postponing as possible the HTTP and only if needed).

[jetersen]

Looks good, one minor improvement can be made

[jetersen]

consider adding checkstyle to jenkinsfile as well:

https://github.com/jenkinsci/platformlabeler-plugin/blob/f8d99f39a629bfcc28eb88c87afa7fc35542ed0e/Jenkinsfile#L7

https://github.com/jenkins-infra/pipeline-library/blob/e2fe66b4ee193c728b1e371a1ce2f9ff9a07d603/vars/buildPlugin.groovy#L83-L92

[jetersen]

Seems like checkstyle is scanning generated files 😢

https://ci.jenkins.io/blue/organizations/jenkins/Plugins%2Fbitbucket-branch-source-plugin/detail/PR-152/8/pipeline/#step-35-log-226

[nfalco79]

Seems like checkstyle is scanning generated files 😢

https://ci.jenkins.io/blue/organizations/jenkins/Plugins%2Fbitbucket-branch-source-plugin/detail/PR-152/8/pipeline/#step-35-log-226

For this reason I have excluded resources (maybe could be setup only for properties files).
EDIT:
I had misunderstood what you wrote about jenkinsfile. Added checkstyle report generation to the Jenkinsfile as request

[nfalco79]

@Casz any news?

[jetersen]

Haven't gotten around to it because of sickness 😢 Will see what I can muster!

[jetersen]

Looks fine except for the use of slf4j logger 😢 if you want the code base to switch logger, it should be done in a single PR.

[nfalco79]

ok reverted

[jetersen]

Your rebase allowed for missed checkstyle it seems 🤭

[nfalco79]

@Casz I do not understand, checkstyle is configured to check java and test sources. The build pass and checkstyle is performed on jenkins build:

[INFO] --- maven-checkstyle-plugin:3.0.0:check (default) @ cloudbees-bitbucket-branch-source ---

[jetersen]

Well your latest commit corrects all that was wrong with the first at moment so all good 😅

[nfalco79]

Well your latest commit corrects all that was wrong with the first at moment so all good 😅

ok so nothingelse to do

[nickbroon]

Has 2.2.15 been published with this fix to https://updates.jenkins.io/ ?

[jetersen]

I uploaded it yesterday, I guess Jenkins CI is having trouble.

[jetersen]

@nickbroon https://repo.jenkins-ci.org/webapp/#/artifacts/browse/tree/General/releases/org/jenkins-ci/plugins/cloudbees-bitbucket-branch-source/2.2.15 would you mind creating a jenkins infra ticket?

[nickbroon]

Where and how do I do that?
Do I use https://issues.jenkins-ci.org/? And if so, what is the component to submit the ticket against?

[jetersen]

Yes https://issues.jenkins-ci.org is used 😅

https://issues.jenkins-ci.org/browse/JENKINS-54401
https://issues.jenkins-ci.org/browse/INFRA-1868