Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(get-fileshare-signed-url) ensure the script is re-entrant to allow concurent calls #854

Merged
merged 2 commits into from
May 3, 2024
Merged

fix(get-fileshare-signed-url) ensure the script is re-entrant to allow concurent calls #854

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
962643b
fix(get-fileshare-signed-url) ensure the script is re-entrant to allo…
dduportal May 3, 2024
2fd7c63
Update resources/get-fileshare-signed-url.sh
dduportal May 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions resources/get-fileshare-signed-url.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,11 @@ set +x

: "${STORAGE_FILESHARE?}" "${STORAGE_NAME?}" "${STORAGE_DURATION_IN_MINUTE?}" "${STORAGE_PERMISSIONS?}"

# Ensure the script is re-entrant by using different `az` configuration dir for each call
dduportal marked this conversation as resolved.
Show resolved Hide resolved
# Ref. https://learn.microsoft.com/en-us/cli/azure/use-azure-cli-successfully?tabs=bash%2Cbash2#concurrent-execution
AZURE_CONFIG_DIR="$(mktemp -d)"
export AZURE_CONFIG_DIR

accountKeyArg=()
shouldLogout="true"
# If a storage account key env var exists, use it instead of a service principal to generate a file share SAS token
Expand Down