Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(get-fileshare-signed-url) ensure the script is re-entrant to allow concurent calls #854

Conversation

dduportal
Copy link
Contributor

@dduportal dduportal commented May 3, 2024

Ref. jenkins-infra/helpdesk#2649

This PR fixes the shell script resources/get-fileshare-signed-url.sh so it is re-entrant to support concurrent calls as part of jenkins-infra/update-center2#777.

The documentation at https://learn.microsoft.com/en-us/cli/azure/use-azure-cli-successfully?tabs=bash%2Cbash2#concurrent-execution shows that we can use a different configuration dir. on each call


Validations:

  • Shellcheck (of course)
  • Ran the script on my local development machine (smoke test: if it smokes then it is bad ;))
  • On the trusted.ci permanent agent:
    • Disabled the puppet agent (to avoid overriding changes)
    • Added the change
    • Waited for 2 consecutive successful builds of update_center2 on trusted.ci

lemeurherve
lemeurherve previously approved these changes May 3, 2024
@dduportal dduportal enabled auto-merge (squash) May 3, 2024 12:42
@dduportal dduportal disabled auto-merge May 3, 2024 12:42
@dduportal dduportal merged commit 0d4b15d into jenkins-infra:master May 3, 2024
0 of 2 checks passed
@dduportal dduportal deleted the fix/infra/get-fileshare-url/re-entrant branch May 3, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants