Remove srt as external from ExoPlayer subtitle profiles #1537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsvanvelzen
force-pushed
the
exo-srt-embed
branch
from
1263130 to
f379455
Compare
|
this breaks direct playing external srt subtitles and forces them to be burned in. Tested using exoplayer with external .srt and a video that doesn't have any embedded subtitles. I've personally not had issues playing embedded subtitles. But my guess is that the "fall through to external handling" logic here may be responsible for issues. |
|
So that means that the server actually allows for multiple delivery methods for a subtitle format.. Didn't know that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had 2 separate entries for srt: external and embed. I guess the server just used the first entry (external). It doesn't really do much because we don't support embedded subs in ExoPlayer anyway.
Changes