Embedded subtitles fail to load #1534

sambartik · 2022-03-19T18:50:59Z

Describe the bug

I have noticed that all of my embedded subtitles fail to load. When I select them, first I get "Loading subtitles" message and after a while the message disappears and a popup appears: "Failed to load subtitles". External subtitles are working.

I believe this is an error on jellyfin androidtv part, since other types of clients can display the very same subtitles OK. Also, it doesn't matter whether the media is transcoded or direct played, the issue occurs in both cases.

Logs

No response

Application version

0.13.0

Where did you install the app from?

Google Play

Device information

Sony Bravia KD-55XF9005

Android version

9

Jellyfin server version

10.7.7

dfrincon · 2022-03-19T20:24:03Z

same error from the first beta 0.13 shiledtv 2017 with external and internal .srt sub, jellyfin 10.8 nightly

nielsvanvelzen · 2022-03-19T20:29:54Z

Did you experience this issue with the previous version of the app (0.12.3)?

dfrincon · 2022-03-19T20:46:18Z

Did you experience this issue with the previous version of the app (0.12.3)?

i have installed now 0.12.3 same problem with internal sub, the problem is with ExoPlayer, with libvlc work.

sambartik · 2022-03-19T21:13:50Z

Did you experience this issue with the previous version of the app (0.12.3)?

I am not sure, I will try to install 0.12.3 back. Hopefully I will figure out how. Will report back.

sambartik · 2022-03-19T22:13:57Z

I have tried 0.12.3, 0.12.2, 0.12.0 and on all of those versions embedded subtitles did not work.

sambartik · 2022-03-19T22:29:30Z

Logs that might help:

03-19 23:23:06.821 27790 27790 D jellyfin-apiclient: Adding request to queue: http://192.168.1.2:9876/jellyfin/Videos/7f03fd462cbb8c86637ef915b3ca8330/7f03fd462cbb8c86637ef915b3ca8330/Subtitles/4/0/Stream.JSON?format=json
03-19 23:23:36.862 27790 27790 E jellyfin-apiclient: VolleyError com.android.volley.TimeoutError: null
03-19 23:23:36.862 27790 27790 E jellyfin-apiclient: com.android.volley.TimeoutError
03-19 23:23:36.862 27790 27790 E jellyfin-apiclient: 	at com.android.volley.toolbox.NetworkUtility.shouldRetryException(NetworkUtility.java:162)
03-19 23:23:36.862 27790 27790 E jellyfin-apiclient: 	at com.android.volley.toolbox.BasicNetwork.performRequest(BasicNetwork.java:145)
03-19 23:23:36.862 27790 27790 E jellyfin-apiclient: 	at com.android.volley.NetworkDispatcher.processRequest(NetworkDispatcher.java:132)
03-19 23:23:36.862 27790 27790 E jellyfin-apiclient: 	at com.android.volley.NetworkDispatcher.processRequest(NetworkDispatcher.java:111)
03-19 23:23:36.862 27790 27790 E jellyfin-apiclient: 	at com.android.volley.NetworkDispatcher.run(NetworkDispatcher.java:90)
03-19 23:23:36.864 27790 27790 E PlaybackController: org.jellyfin.apiclient.model.net.HttpException: VolleyError com.android.volley.TimeoutError: 
03-19 23:23:36.864 27790 27790 E PlaybackController: 	at org.jellyfin.apiclient.interaction.VolleyErrorListener.onErrorResponse(VolleyErrorListener.java:25)

steelersfan7 · 2022-03-19T23:09:08Z

I get this same issue with a similar error. The jellyfin server logs indicate that ffmpeg extraction complete. When that happens 1-5 minutes(depending on the size of the file) android app will play the subtitles as they should. For some reason exoplayer is reporting to the server that it can't play srt subs(internal or external). There should be no reason to extract the srt files as best I can tell

2022-03-19 19:07:51.807 4423-4423/org.jellyfin.androidtv.debug E/jellyfin-apiclient: VolleyError com.android.volley.TimeoutError: null
com.android.volley.TimeoutError
at com.android.volley.toolbox.NetworkUtility.shouldRetryException(NetworkUtility.java:162)
at com.android.volley.toolbox.BasicNetwork.performRequest(BasicNetwork.java:145)
at com.android.volley.NetworkDispatcher.processRequest(NetworkDispatcher.java:132)
at com.android.volley.NetworkDispatcher.processRequest(NetworkDispatcher.java:111)
at com.android.volley.NetworkDispatcher.run(NetworkDispatcher.java:90)
2022-03-19 19:07:51.808 4423-4423/org.jellyfin.androidtv.debug E/PlaybackController: Error downloading subtitles
org.jellyfin.apiclient.model.net.HttpException: VolleyError com.android.volley.TimeoutError:
at org.jellyfin.apiclient.interaction.VolleyErrorListener.onErrorResponse(VolleyErrorListener.java:25)
at com.android.volley.Request.deliverError(Request.java:648)
at com.android.volley.ExecutorDelivery$ResponseDeliveryRunnable.run(ExecutorDelivery.java:104)
at android.os.Handler.handleCallback(Handler.java:883)
at android.os.Handler.dispatchMessage(Handler.java:100)
at android.os.Looper.loop(Looper.java:214)
at android.app.ActivityThread.main(ActivityThread.java:7356)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:492)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:930)
Caused by: com.android.volley.TimeoutError
at com.android.volley.toolbox.NetworkUtility.shouldRetryException(NetworkUtility.java:162)
at com.android.volley.toolbox.BasicNetwork.performRequest(BasicNetwork.java:145)
at com.android.volley.NetworkDispatcher.processRequest(NetworkDispatcher.java:132)
at com.android.volley.NetworkDispatcher.processRequest(NetworkDispatcher.java:111)
at com.android.volley.NetworkDispatcher.run(NetworkDispatcher.java:90)

zilexa · 2022-03-19T23:35:51Z

After updating Jellyfin server then rebooting AndroidTV, the issue was gone but I only tested 1 episode.

steelersfan7 · 2022-03-19T23:46:33Z

Yeah, but before you did those things, did you try and use the subtitle? Once you use a subtitle even once, it will load fine. Also, this only affects subrips, srt external. PGS etc load fine

sambartik · 2022-03-19T23:47:07Z

After doing some more poking myself, I have found that the error was due to a timeout to jellyfin API endpoint. The request took so long because on the jellyfin backend's side the embedded subtitles were being extracted from the mkv file itself by ffmpeg. The extracted subtitle file was then saved to /config/data/data/subtitles folder.

After the ffmpeg extraction was successfully completed, I had to manually switch to another subtitle and back to get it to display.

OK.

My questions are:

Is the "Allow extraction on the fly" respected in my case? Despite having it disabled, the embedded subtitles were extracted via ffmpeg when I requested them in jellyfin android tv app.
I had number of cases, where these extracted subtitles were completely blank. Maybe an ffmpeg error occured? Does closing the player in android tv app in the middle of subtitles extraction on jellyfin backend somehow trigger an ffmpeg error and thus results in a blank extracted subtitle?

steelersfan7 · 2022-03-19T23:49:07Z

This is my findings too. I think exoplayer should be fully capable of playing subrips, SRT files natively, with no transcoding.

I understand that option only works for like one client, Kodi maybe?
I think the subtitles are extracted server side. I can't imagine the android tv app being reset would cause it to be blank

sambartik · 2022-03-19T23:53:11Z

I can't imagine the android tv app being reset would cause it to be blank

I meant it like this. The ATV client sends to the server that it has exited the player and stopped the stream to the backend. And that would result in backend killing the ffmpeg extraction process which would left blank file. This is pure speculation though.

steelersfan7 · 2022-03-19T23:55:58Z

Yeah, sounds like it might be a seperate issue, or a sympton. In theory, it shouldnt be extracting anyway.

nielsvanvelzen · 2022-03-20T09:55:30Z

Can you try with #1537? (https://github.com/jellyfin/jellyfin-androidtv/suites/5726982406/artifacts/189477527)

steelersfan7 · 2022-03-20T16:20:00Z

Seems to still not work for me on the simulator

sambartik · 2022-03-20T17:58:00Z

Did not work for me as well.

nielsvanvelzen · 2022-03-20T20:50:40Z

Looking further in the code I found this part:

jellyfin-androidtv/app/src/main/java/org/jellyfin/androidtv/ui/playback/PlaybackController.java

Lines 942 to 953 in be89cf2

    
           case Embed: 
        
               if (!mVideoManager.isNativeMode()) { 
        
                   if (mFragment != null) 
        
                       mFragment.addManualSubtitles(null); // in case these were on 
        
                   if (!mVideoManager.setSubtitleTrack(index, getCurrentlyPlayingItem().getMediaStreams())) { 
        
                       // error selecting internal subs 
        
                       if (mFragment != null) 
        
                           Utils.showToast(mFragment.getContext(), mFragment.getString(R.string.msg_unable_load_subs)); 
        
                   } 
        
                   break; 
        
               } 
        
               // not using vlc - fall through to external handling

This makes me believe we don't support embedded subtitles at all and the app will always request the server to extract them when ExoPlayer is used. LibVLC should support embedded subtitles without extraction already (although the linked PR might be required for it to actually work).

steelersfan7 · 2022-03-20T21:03:37Z

But in theory, exoplayer should be able to support embedded subs right?

sambartik · 2022-03-20T21:08:52Z

Is it just me or LibVLC still requires jellyfin to extract embedded subtitles? I have tried playing media on the artefact version linked above and made no difference. With the exception that for some reason LibVLC required to transcode audio as well and Exoplayer did not.

nielsvanvelzen · 2022-03-20T21:10:49Z

But in theory, exoplayer should be able to support embedded subs right?

Yes but it's not implemented in our code

Is it just me or LibVLC still requires jellyfin to extract embedded subtitles?

I pushed a new change to the linked pull request when I posted my previous message, the newer artifact should work with LibVLC. (https://github.com/jellyfin/jellyfin-androidtv/suites/5729875269/artifacts/189681637)

steelersfan7 · 2022-03-20T22:40:03Z

But in theory, exoplayer should be able to support embedded subs right?

Yes but it's not implemented in our code

Something to look forward to in the new playback rewrite, eventually?

nielsvanvelzen · 2022-03-21T07:43:46Z

Something to look forward to in the new playback rewrite, eventually?

Yeah I'll definitely implement it in the rewrite.

zilexa · 2022-03-23T17:11:32Z

After updating Jellyfin server then rebooting AndroidTV, the issue (SRT subs) was gone but I only tested 1 episode.

Yeah, but before you did those things, did you try and use the subtitle? Once you use a subtitle even once, it will load fine. Also, this only affects subrips, srt external. PGS etc load fine

I tested with never played content instead of stuff I had already tested.
After updating Server and rebooting AndroidTV, SRT subtitles for new content no longer fail but it does take quite a long time for them to load. I often have to rewind or restart the content because I missed the first 20 sec --> This seems to indicate Jellyfin is trying to do something with the SRT file instead of just loading them?

This is on a ShieldTV Pro 2019.

quaintdev · 2022-04-02T04:58:57Z

What I had observed was when I switch back default player from ExoPlayer to Auto the embedded subtitles work.

giacomofabbri · 2022-04-05T18:08:59Z

I have the same error on my Fire TV2 using both ExoPlayer and Auto, please I’m desperate to use always Jellyfin and not Plex, thanks

quaintdev · 2022-04-14T15:58:26Z

The issue is I think when selected "Auto" as playback option it uses libVlc which does not show option to Zoom but it loads subtitles. On other hand exo player has option to zoom but it cannot load subtitles. So either I have to watch video with black strips at top/bottom or I can zoom but not have subtitles!

I should be able to zoom video and view subtitle at same time.

axel-lebourhis · 2022-04-16T13:36:57Z

Hey all, juste wanted to report I have the same issue on my shield, app version is the latest. I'm a new user so I don't have experience with previous ones.
I'm not having the issue with Plex, so it's mot the media file.

nielsvanvelzen · 2022-04-16T13:58:16Z

Closing as duplicate of #145.

sambartik added the bug Something isn't working label Mar 19, 2022

nielsvanvelzen mentioned this issue Mar 20, 2022

Remove srt as external from ExoPlayer subtitle profiles #1537

Closed

nielsvanvelzen closed this as completed Apr 16, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Embedded subtitles fail to load #1534

Embedded subtitles fail to load #1534

sambartik commented Mar 19, 2022

dfrincon commented Mar 19, 2022 •

edited

Loading

nielsvanvelzen commented Mar 19, 2022

dfrincon commented Mar 19, 2022 •

edited

Loading

sambartik commented Mar 19, 2022

sambartik commented Mar 19, 2022

sambartik commented Mar 19, 2022

steelersfan7 commented Mar 19, 2022 •

edited

Loading

zilexa commented Mar 19, 2022

steelersfan7 commented Mar 19, 2022 •

edited

Loading

sambartik commented Mar 19, 2022

steelersfan7 commented Mar 19, 2022

sambartik commented Mar 19, 2022

steelersfan7 commented Mar 19, 2022

nielsvanvelzen commented Mar 20, 2022

steelersfan7 commented Mar 20, 2022

sambartik commented Mar 20, 2022

nielsvanvelzen commented Mar 20, 2022

steelersfan7 commented Mar 20, 2022

sambartik commented Mar 20, 2022

nielsvanvelzen commented Mar 20, 2022

steelersfan7 commented Mar 20, 2022

nielsvanvelzen commented Mar 21, 2022

zilexa commented Mar 23, 2022 •

edited

Loading

quaintdev commented Apr 2, 2022

giacomofabbri commented Apr 5, 2022

quaintdev commented Apr 14, 2022 •

edited

Loading

axel-lebourhis commented Apr 16, 2022

nielsvanvelzen commented Apr 16, 2022

Embedded subtitles fail to load #1534

Embedded subtitles fail to load #1534

Comments

sambartik commented Mar 19, 2022

Describe the bug

Logs

Application version

Where did you install the app from?

Device information

Android version

Jellyfin server version

dfrincon commented Mar 19, 2022 • edited Loading

nielsvanvelzen commented Mar 19, 2022

dfrincon commented Mar 19, 2022 • edited Loading

sambartik commented Mar 19, 2022

sambartik commented Mar 19, 2022

sambartik commented Mar 19, 2022

steelersfan7 commented Mar 19, 2022 • edited Loading

zilexa commented Mar 19, 2022

steelersfan7 commented Mar 19, 2022 • edited Loading

sambartik commented Mar 19, 2022

steelersfan7 commented Mar 19, 2022

sambartik commented Mar 19, 2022

steelersfan7 commented Mar 19, 2022

nielsvanvelzen commented Mar 20, 2022

steelersfan7 commented Mar 20, 2022

sambartik commented Mar 20, 2022

nielsvanvelzen commented Mar 20, 2022

steelersfan7 commented Mar 20, 2022

sambartik commented Mar 20, 2022

nielsvanvelzen commented Mar 20, 2022

steelersfan7 commented Mar 20, 2022

nielsvanvelzen commented Mar 21, 2022

zilexa commented Mar 23, 2022 • edited Loading

quaintdev commented Apr 2, 2022

giacomofabbri commented Apr 5, 2022

quaintdev commented Apr 14, 2022 • edited Loading

axel-lebourhis commented Apr 16, 2022

nielsvanvelzen commented Apr 16, 2022

dfrincon commented Mar 19, 2022 •

edited

Loading

dfrincon commented Mar 19, 2022 •

edited

Loading

steelersfan7 commented Mar 19, 2022 •

edited

Loading

steelersfan7 commented Mar 19, 2022 •

edited

Loading

zilexa commented Mar 23, 2022 •

edited

Loading

quaintdev commented Apr 14, 2022 •

edited

Loading