Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent notification from being dismissed while playback is active #1290

Merged
merged 5 commits into from
Mar 13, 2024
Merged

Prevent notification from being dismissed while playback is active #1290

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
49a3dea
prevent notification from being dismissed while playback is active
taitsmith Feb 6, 2024
5ff8f77
edit comment
taitsmith Mar 9, 2024
dd82d3d
Merge branch 'jellyfin:master' into notification-fix-1284
taitsmith Mar 9, 2024
c6e4e27
Merge branch 'master' into notification-fix-1284
taitsmith Mar 10, 2024
ae00955
fix detekt error
taitsmith Mar 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions app/src/main/java/org/jellyfin/mobile/player/interaction/PlayerNotificationHelper.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,10 @@ class PlayerNotificationHelper(private val viewModel: PlayerViewModel) : KoinCom
}
setContentIntent(buildContentIntent())
setDeleteIntent(buildDeleteIntent())

//prevents the notification from being dismissed while playback is ongoing
//which causes video to stop. see #1284
taitsmith marked this conversation as resolved.
Show resolved Hide resolved
setOngoing(player.isPlaying)
}.build()

nm.notify(VIDEO_PLAYER_NOTIFICATION_ID, notification)
Expand Down
Loading