Prevent notification from being dismissed while playback is active #1290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maxr1998
reviewed
Feb 25, 2024
app/src/main/java/org/jellyfin/mobile/player/interaction/PlayerNotificationHelper.kt
Outdated
Show resolved
Hide resolved
Maxr1998
previously approved these changes
Mar 11, 2024
|
Thanks! Could you also please look into the detekt failure and fix it before I merge? |
Maxr1998
approved these changes
Mar 13, 2024
|
Thank you! |
Maxr1998
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds a call to
setOngoing()during the creation of the playback notification to determine if the notification can be dismissed. Ongoing notifications won't be dismissed by clicking 'clear all' in the system dropdown menu.Issues
Fixes #1284