Update default xml for MailChimp #170
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any updates on this? |
|
@HaoZeke If you could rebase |
pathawks
requested changes
Jan 27, 2018
| @@ -74,7 +74,7 @@ | |||
| {% unless post_image contains "://" %} | |||
| {% assign post_image = post_image | absolute_url | xml_escape %} | |||
| {% endunless %} | |||
| <media:thumbnail xmlns:media="http://search.yahoo.com/mrss/" url="{{ post_image }}" /> | |||
| <media:content xmlns:media="http://search.yahoo.com/mrss/" url="{{ post_image }}" medium="image" /> | |||
There was a problem hiding this comment.
What is this about? Can you link to some documentation explaining this?
I don’t want to get rid of media:thumbnail, it’s used by feed readers.
|
So the current layout isn't picked up by mailchimp which expects media:content I'll update this sometime soon. |
|
You could maybe put them both in the same We may have to do some experiments to see how this will be rendered in various feed readers. |
|
Fixed in #290 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.