Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Custom Tags to Entry #169

Closed
bsullins opened this issue Apr 16, 2017 · 4 comments
Closed

Adding Custom Tags to Entry #169

bsullins opened this issue Apr 16, 2017 · 4 comments

Comments

@bsullins
Copy link

bsullins commented Apr 16, 2017

The image from my post is being pulled in to the feed but I need to change the actual tag that is displayed so I can use it in my MailChimp campaign. How could I customize (add/change) some of the output of the feed to conform to what MailChimp is looking for?

Current Output

<media:thumbnail xmlns:media="http://search.yahoo.com/mrss/" 
url="https://bsullins.github.io/teslanomics//teslanomics/tesla-battery-lifespan-cover-small-compressed.jpg"/>
</entry>

Needed Output

<media:content xmlns:media="http://search.yahoo.com/mrss/" 
url="https://bsullins.github.io/teslanomics//teslanomics/tesla-battery-lifespan-cover-small-compressed.jpg" 
type="image/jpg"/>
</entry>
@pathawks
Copy link
Member

You need the addition of a type attribute?

This is not currently possible, and we don't have a way of detecting the image type so adding it would be non-trivial.

That said, I’d be happy to review a PR that added this feature. I do see the value.

@bsullins
Copy link
Author

@pathawks yes, for this to work I need a type attribute and to change from media:thumbnail to media:content

Here is the spec from Mailchimp - http://kb.mailchimp.com/merge-tags/rss-merge-tags

@HaoZeke
Copy link

HaoZeke commented Apr 19, 2017

#170 Should fix Mailchimp considering that their specifications allow for a more file type agnostic method of signalling images.

@jekyllbot
Copy link
Contributor

This issue has been automatically marked as stale because it has not been commented on for at least two months.

The resources of the Jekyll team are limited, and so we are asking for your help.

If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.

If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial.

This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions.

@jekyll jekyll locked and limited conversation to collaborators Apr 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants