[slightly less scuffed bugfix]: Update table rating/favorite when updated anywhere … #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…else Modify player store to have temporary state for favorite/rating update Add effect handler for `virtual-table` to update rating/favorite for players Note that this does not handle song grid view. Using a similar handler for gird view did not work, as it appeared to result in inconsistent state. Finally, this is probably not the optimal solution. Performance appears fine for ~20k items, but no guarantees.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jeffvli
reviewed
Aug 23, 2024
| @@ -248,7 +249,7 @@ export const PlaylistDetailSongListContent = ({ tableRef }: PlaylistDetailConten | |||
| onCellContextMenu: handleContextMenu, | |||
| status, | |||
| }} | |||
| getRowId={(data) => data.data.uniqueId} | |||
| getRowId={(data) => data.data.id} | |||
There was a problem hiding this comment.
Duplicate songs can exist in playlists which is why uniqueId is used here.
kgarner7
changed the title
|
Performance:
|
jeffvli
reviewed
Sep 3, 2024
src/renderer/features/playlists/components/playlist-detail-content.tsx
Outdated
Show resolved
Hide resolved
jeffvli
reviewed
Sep 3, 2024
src/renderer/features/playlists/components/playlist-detail-content.tsx
Outdated
Show resolved
Hide resolved
spiceratops
referenced
this pull request
in spiceratops/k8s-gitops
Sep 3, 2024
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/jeffvli/feishin](https://redirect.github.com/jeffvli/feishin) | minor | `0.7.3` -> `0.8.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>jeffvli/feishin (ghcr.io/jeffvli/feishin)</summary> ### [`v0.8.0`](https://redirect.github.com/jeffvli/feishin/releases/tag/v0.8.0): 0.8.0 [Compare Source](https://redirect.github.com/jeffvli/feishin/compare/v0.7.3...v0.8.0) As always, thanks to contributors! #### Highlights - (UI) Added alternative album header styling using blurred image ([#​717](https://redirect.github.com/jeffvli/feishin/issues/717)) - (UI) Added play countto album header ([#​720](https://redirect.github.com/jeffvli/feishin/issues/720)) - (UI) Fixed synchronization between playqueue rating/favorite values and detail pages ([#​707](https://redirect.github.com/jeffvli/feishin/issues/707)) - (UI) Fixed issue where in-page text could not be deselected if selected using keyboard shortcuts ([#​723](https://redirect.github.com/jeffvli/feishin/issues/723)) #### What's Changed - Bump electron-updater from 4.6.5 to 6.3.0 in the npm_and_yarn group across 1 directory by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/jeffvli/feishin/pull/687](https://redirect.github.com/jeffvli/feishin/pull/687) - Add play count to albums by [@​pyxfluff](https://redirect.github.com/pyxfluff) in [https://github.com/jeffvli/feishin/pull/720](https://redirect.github.com/jeffvli/feishin/pull/720) - Album blur, allow clicking the playerbar to toggle the player, misc changes by [@​pyxfluff](https://redirect.github.com/pyxfluff) in [https://github.com/jeffvli/feishin/pull/717](https://redirect.github.com/jeffvli/feishin/pull/717) - Bump electron-updater from 6.3.0 to 6.3.1 in the npm_and_yarn group across 1 directory by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/jeffvli/feishin/pull/688](https://redirect.github.com/jeffvli/feishin/pull/688) - \[qol]: adjust rules for user-select by [@​iiPythonx](https://redirect.github.com/iiPythonx) in [https://github.com/jeffvli/feishin/pull/723](https://redirect.github.com/jeffvli/feishin/pull/723) - \[slightly less scuffed bugfix]: Update table rating/favorite when updated anywhere … by [@​kgarner7](https://redirect.github.com/kgarner7) in [https://github.com/jeffvli/feishin/pull/707](https://redirect.github.com/jeffvli/feishin/pull/707) **Full Changelog**: jeffvli/feishin@v0.7.3...v0.8.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC42NC4xIiwidXBkYXRlZEluVmVyIjoiMzguNjQuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsicmVub3ZhdGUvY29udGFpbmVyIiwidHlwZS9taW5vciJdfQ==-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…else
Modify player store to have temporary state for favorite/rating update Add effect handler for
virtual-tableto update rating/favorite for playersNote that this does not handle song grid view.
Using a similar handler for gird view did not work, as it appeared to result in inconsistent state.
Finally, this is probably not the optimal solution. Performance appears fine for ~20k items, but no guarantees.