Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top song expanding over 10 songs on One artist. #729

Closed
Blavkentropy1 opened this issue Sep 5, 2024 · 3 comments
Closed

Top song expanding over 10 songs on One artist. #729

Blavkentropy1 opened this issue Sep 5, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@Blavkentropy1
Copy link

Blavkentropy1 commented Sep 5, 2024

Expected Behavior

The Top 10 artist songs are shown, and no more

Current Behavior

The List skips the top song 9, and goes to 10, then showing the same song in a loop.
This the puts the same song on a list courting up i.e 11, 12,13 etc. Making the program unusable, and eventually leading to a crash.

I cant replicate this with any other artist so far.
I Cant find out how to get Verbose Faishin logs, please advise if there is a way to do this.

Feishing V0 8 1 Bug
Feishing V0 8 1 Bug2
Feishing V0 8 1 Bug3

Steps to Reproduce

  1. Open Feishin V0.8.0 or V0.8.1
  2. Select the Artist "African Imperial Wizard"
  3. The page loads and the Top Songs expands until it crashes.

Possible Solution

No response

Context

This only seems to effect this one artist on V 0.8.0 and 8.1. I cant replicate this on any other artist at this time.
This loops different songs every time.

Fault Finding Done
Testing on 0.7.3 works correctly.
Testing on 2 windows desktops. Both have the same issue through Local connection and External.
Moved the folder out of the monitored directory. Re-scanned Navidrome, then added the files back. Same issue.
To my knowledge, there is no odd Metadata.
Logs on Navidrome or Feishin don't show anything.

I spun up a docker container to test this with the below settings.
I could replicate on V0.8.0 and V0.8.1 but not V0.7.3

docker run --name feishin -p 9180:9180 ghcr.io/jeffvli/feishin:latest

Application version

V0.8.0, V0.8.1

Operating System and version

Windows 11 (10.0.22631.4037) & Docker

Server and Version

Navidrome 0.52.5

Node Version (if developing locally)

No response

@Blavkentropy1 Blavkentropy1 added the bug Something isn't working label Sep 5, 2024
@Blavkentropy1
Copy link
Author

Found another Band.
I suspect this is due to it having special characters in the title.
Artist
ᚾᛟᚢ ᛁᛁ // ᚦᛟᚦ ᚷᛁᚷ
Feishing V0 8 1 Bug4

@jeffvli
Copy link
Owner

jeffvli commented Sep 5, 2024

The console message indicates that it's erroring due to duplicate rows.

I believe it's due to changes made in #707 with the changes made in how row ids are calculated in the top songs list.

The fetched data should probably be filtered to remove any duplicate entries before it's rendered.
@kgarner7 Can you take a look?

@kgarner7
Copy link
Collaborator

kgarner7 commented Sep 5, 2024

e6bd8de

@kgarner7 kgarner7 closed this as completed Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants