-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The upgrade from v6.4.0 to v6.4.1 results in empty table content when used in our product. #285
Comments
Hey @attiasas! Thanks for reporting this. |
Yes @jedib0t, |
@attiasas I'm unable to find a link to the CircleCI execution logs. Is this something private? If not, can you share the links? I tried running the PrintTable code locally with tests and I couldn't see the issue. |
Hi @jedib0t, The links to the logs are not public; however, I've attached the full logs, with and without the issue, in the initial comment. I'm unable to replicate this issue locally as well. It only occurs when executing the code via CircleCI. When you run the PrintTable code locally, you won't encounter this issue. To reproduce it on CircleCI, you can easily sign up for a free CircleCI account, create a repository, and add a |
any update? |
Not yet. I'll take a look this weekend. |
|
Nevermind. Was able to reproduce it with your https://github.com/jedib0t/go-pretty/blob/circleci-fix/cmd/demo-jfrog-utils/demo.go |
Hey @attiasas ... managed to find the issue.
I will update the logic in go-pretty to be able to handle this bad input. You should be able to upgrade to the next version of go-pretty and test it. However, please try to update the I will ping you once a new release is ready. |
Hey @attiasas the release https://github.com/jedib0t/go-pretty/releases/tag/v6.5.0 should have a fix for you. If it does not fix the issue, feel free to reopen this bug. |
Describe the bug
After upgrading to v6.4.1, the tables' content becomes empty when printed specifically on the CircleCI terminal. This issue has been reported within our product that utilizes these tables, as reported to us here: jfrog/jfrog-cli#1858.
I was able to pinpoint this issue to a single change in the versions.
To Reproduce
To reproduce the issue, execute a code on CircleCI with version
6.4.1
+ that prints table content using the provided configurations, as showcased in Our code sample or the following code snippet:Expected behavior
At version
v6.4.0
the content looked like this:Full Snippet example
Screenshots
When updating to version
v6.4.1
the content looked like this:Snippet example
Software (please complete the following information):
linux
/mac
1.20
The text was updated successfully, but these errors were encountered: