table: handle negative WidthMax values; fixes #285

jedib0t · Jan 4, 2024 · a5fc99a · a5fc99a
1 parent a0c7cb6
commit a5fc99a
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/table/config.go b/table/config.go
@@ -71,7 +71,7 @@ type ColumnConfig struct {
 }
 
 func (c ColumnConfig) getWidthMaxEnforcer() WidthEnforcer {
-	if c.WidthMax == 0 {
+	if c.WidthMax <= 0 {
 		return widthEnforcerNone
 	}
 	if c.WidthMaxEnforcer != nil {

diff --git a/table/config_test.go b/table/config_test.go
@@ -34,6 +34,20 @@ func TestColumnConfig_getWidthMaxEnforcer(t *testing.T) {
 		assert.Equal(t, "1234567890", widthEnforcer("1234567890", 1000))
 	})
 
+	t.Run("negative width enforcer", func(t *testing.T) {
+		cc := ColumnConfig{
+			WidthMax: -10,
+		}
+
+		widthEnforcer := cc.getWidthMaxEnforcer()
+		assert.Equal(t, "1234567890", widthEnforcer("1234567890", 0))
+		assert.Equal(t, "1234567890", widthEnforcer("1234567890", 1))
+		assert.Equal(t, "1234567890", widthEnforcer("1234567890", 5))
+		assert.Equal(t, "1234567890", widthEnforcer("1234567890", 10))
+		assert.Equal(t, "1234567890", widthEnforcer("1234567890", 100))
+		assert.Equal(t, "1234567890", widthEnforcer("1234567890", 1000))
+	})
+
 	t.Run("custom width enforcer (1)", func(t *testing.T) {
 		cc := ColumnConfig{
 			WidthMax:         10,