Polish "RowSetFactory is costly to build and is built very often"

jdbc-observations · Oct 12, 2024 · 838ed45 · 838ed45
1 parent 681f0cb
commit 838ed45
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/main/java/net/ttddyy/dsproxy/proxy/CachedRowSetResultSetProxyLogicFactory.java b/src/main/java/net/ttddyy/dsproxy/proxy/CachedRowSetResultSetProxyLogicFactory.java
@@ -34,9 +34,9 @@ public class CachedRowSetResultSetProxyLogicFactory implements ResultSetProxyLog
 
     public CachedRowSetResultSetProxyLogicFactory() {
         try {
-           this.rowSetFactory = RowSetProvider.newFactory();
-        } catch (SQLException e) {
-           throw new RuntimeException(e);
+            this.rowSetFactory = RowSetProvider.newFactory();
+        } catch (SQLException ex) {
+            throw new RuntimeException(ex);
         }
     }
 
@@ -50,7 +50,7 @@ protected ResultSet getCachedRowSet(ResultSet resultSet) {
         try {
             // CachedRowSet only works with non-null ResultSet
             if (resultSet.getMetaData().getColumnCount() > 0) {
-                CachedRowSet cachedRowSet = rowSetFactory.createCachedRowSet();
+                CachedRowSet cachedRowSet = this.rowSetFactory.createCachedRowSet();
                 cachedRowSet.populate(resultSet);
                 return cachedRowSet;
             } else {