RowSetFactory is costly to build and is built very often

jdbc-observations · Oct 11, 2024 · 681f0cb · 681f0cb
1 parent 3c4b168
commit 681f0cb
Showing 1 changed file with 10 additions and 1 deletion.
diff --git a/src/main/java/net/ttddyy/dsproxy/proxy/CachedRowSetResultSetProxyLogicFactory.java b/src/main/java/net/ttddyy/dsproxy/proxy/CachedRowSetResultSetProxyLogicFactory.java
@@ -30,6 +30,16 @@
 @IgnoreJRERequirement
 public class CachedRowSetResultSetProxyLogicFactory implements ResultSetProxyLogicFactory {
 
+    private final RowSetFactory rowSetFactory;
+
+    public CachedRowSetResultSetProxyLogicFactory() {
+        try {
+           this.rowSetFactory = RowSetProvider.newFactory();
+        } catch (SQLException e) {
+           throw new RuntimeException(e);
+        }
+    }
+
     @Override
     public ResultSetProxyLogic create(ResultSet resultSet, ConnectionInfo connectionInfo, ProxyConfig proxyConfig) {
         ResultSet cachedRowSet = getCachedRowSet(resultSet);
@@ -40,7 +50,6 @@ protected ResultSet getCachedRowSet(ResultSet resultSet) {
         try {
             // CachedRowSet only works with non-null ResultSet
             if (resultSet.getMetaData().getColumnCount() > 0) {
-                RowSetFactory rowSetFactory = RowSetProvider.newFactory();
                 CachedRowSet cachedRowSet = rowSetFactory.createCachedRowSet();
                 cachedRowSet.populate(resultSet);
                 return cachedRowSet;