chore(typing): improve typing of WrappedFn #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
sileht
force-pushed
the
fix-typing
branch
3 times, most recently
from
b888290 to
5783e0c
Compare
jd
previously approved these changes
Feb 9, 2023
This change improves the typing of WrappedFn. It makes explictly the two signatures of tenacity.retry() with overload. This avoids mypy thinking the return type is `<nothing>`
jd
approved these changes
Feb 9, 2023
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Feb 11, 2023
Tenacity MyPy integration has been broken in 8.2.0, but 8.2.1 seems to fix it. Test fix provided in jd/tenacity#390 Related: apache#29411
potiuk
added a commit
to apache/airflow
that referenced
this pull request
Feb 12, 2023
* Bring back fixed tenacity. Tenacity MyPy integration has been broken in 8.2.0, but 8.2.1 seems to fix it. Test fix provided in jd/tenacity#390 Related: #29411 Co-authored-by: Tzu-ping Chung <[email protected]>
pierrejeambrun
pushed a commit
to apache/airflow
that referenced
this pull request
Mar 7, 2023
* Bring back fixed tenacity. Tenacity MyPy integration has been broken in 8.2.0, but 8.2.1 seems to fix it. Test fix provided in jd/tenacity#390 Related: #29411 Co-authored-by: Tzu-ping Chung <[email protected]> (cherry picked from commit 28806a3)
pierrejeambrun
pushed a commit
to apache/airflow
that referenced
this pull request
Mar 8, 2023
* Bring back fixed tenacity. Tenacity MyPy integration has been broken in 8.2.0, but 8.2.1 seems to fix it. Test fix provided in jd/tenacity#390 Related: #29411 Co-authored-by: Tzu-ping Chung <[email protected]> (cherry picked from commit 28806a3)
ahidalgob
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Jun 12, 2023
* Bring back fixed tenacity. Tenacity MyPy integration has been broken in 8.2.0, but 8.2.1 seems to fix it. Test fix provided in jd/tenacity#390 Related: #29411 Co-authored-by: Tzu-ping Chung <[email protected]> GitOrigin-RevId: 28806a32005583f06c8ee26b808d84d2a5593ab7
ahidalgob
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Jul 17, 2023
* Bring back fixed tenacity. Tenacity MyPy integration has been broken in 8.2.0, but 8.2.1 seems to fix it. Test fix provided in jd/tenacity#390 Related: #29411 Co-authored-by: Tzu-ping Chung <[email protected]> (cherry picked from commit 28806a32005583f06c8ee26b808d84d2a5593ab7) GitOrigin-RevId: 6bdac035d696e78f3e68cb2943d5444ea4886945
ahidalgob
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Nov 7, 2023
* Bring back fixed tenacity. Tenacity MyPy integration has been broken in 8.2.0, but 8.2.1 seems to fix it. Test fix provided in jd/tenacity#390 Related: #29411 Co-authored-by: Tzu-ping Chung <[email protected]> GitOrigin-RevId: 28806a32005583f06c8ee26b808d84d2a5593ab7
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Sep 19, 2024
* Bring back fixed tenacity. Tenacity MyPy integration has been broken in 8.2.0, but 8.2.1 seems to fix it. Test fix provided in jd/tenacity#390 Related: #29411 Co-authored-by: Tzu-ping Chung <[email protected]> GitOrigin-RevId: 28806a32005583f06c8ee26b808d84d2a5593ab7
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Nov 8, 2024
* Bring back fixed tenacity. Tenacity MyPy integration has been broken in 8.2.0, but 8.2.1 seems to fix it. Test fix provided in jd/tenacity#390 Related: #29411 Co-authored-by: Tzu-ping Chung <[email protected]> GitOrigin-RevId: 28806a32005583f06c8ee26b808d84d2a5593ab7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change improves the typing of WrappedFn.
It makes explictly the two signatures of tenacity.retry() with overload.
This avoids mypy thinking the return type is
<nothing>